Ensuring the correctness of req.params using express validator

Question

Ensuring the correctness of req.params using express validator

I need the user to input a specific account number in the endpoint, and I've been trying to validate this parameter against my database. However, I'm having trouble getting it to work correctly. Can you please point out what I might be doing wrong?

My validation logic:

const validateReq: [
param('accountNumber').exists().custom(acctNo => accountNumberExist(acctNo)),]

Function for checking account number existence:

    function accountNumberExist(inputAcct) {
    const isfound = accounts.find(account => account.accountNumber === inputAcct);
    if (isfound === undefined) throw new Error('Account Number not found');
  }

Data in my accounts file:

    const accounts = [
  {
    id: 1,
    accountNumber: 1234567890,
    createdOn: new Date(),
    owner: 1,
    type: 'current',
    balance: 23444.43,
    status: 'active',
  },
  {
    id: 2,
    accountNumber: 1234167890,
    createdOn: new Date(),
    owner: 1,
    type: 'savings',
    balance: 2233444.43,
    status: 'active',
  },
  {
    id: 3,
    accountNumber: 9987654321,
    createdOn: new Date(),
    owner: 2,
    type: 'saving',
    balance: 73444.43,
    status: 'active',
  },
];

Despite the fact that the requested parameter exists in my accounts database, I keep receiving the error message 'Account Number not found'. Any insights on why this could be happening?

javascript api express endpoint express-validator

Answer 1

Answer №1

When using express middleware, params are automatically parsed as strings. For example, if a request is made to the path specified as /some/1000,

app.get('/some/:path', (req, res, next) => {
  console.log(typeof req.param.path)
  // outputs string
})

To ensure that the incoming parameter is treated as an integer (Number), you should parse it accordingly since the accountNumber data is stored as an integer. You can achieve this by adding toInt in the chain as shown below:

const validateReq: [
  param('accountNumber').exists().toInt().custom(acctNo => accountNumberExist(acctNo)),
]

Answer 2

When using express middleware, params are automatically parsed as strings. For example, if a request is made to the path specified as /some/1000,

app.get('/some/:path', (req, res, next) => {
  console.log(typeof req.param.path)
  // outputs string
})

To ensure that the incoming parameter is treated as an integer (Number), you should parse it accordingly since the accountNumber data is stored as an integer. You can achieve this by adding toInt in the chain as shown below:

const validateReq: [
  param('accountNumber').exists().toInt().custom(acctNo => accountNumberExist(acctNo)),
]

Answer 3

Answer №2

It seems that the accountNumber inside accounts array is a number, while req.params.accountNumber is a string. To resolve this, you will need to convert the data type accordingly. You can achieve this by using the following code snippet:

    accountNumberExist(inputAcct) {
        const isfound = accounts.find(account => account.accountNumber.toString() === inputAcct);
        if (isfound === undefined) throw new Error('Account Number not found');
  }

Answer 4

It seems that the accountNumber inside accounts array is a number, while req.params.accountNumber is a string. To resolve this, you will need to convert the data type accordingly. You can achieve this by using the following code snippet:

    accountNumberExist(inputAcct) {
        const isfound = accounts.find(account => account.accountNumber.toString() === inputAcct);
        if (isfound === undefined) throw new Error('Account Number not found');
  }

Answer 5

Answer №3

It appears that the issue lies in your query. The find method operates asynchronously, causing the isfound property to not contain the expected data. To address this, I have implemented a straightforward solution using promises which has proven effective.

// Function to check if account number exists.
accountNumberExist(inputAcct) {
    return accounts.find({accountNumber: inputAcct})
    .then(result => {
        if (result.length == 0) {
            console.log("Account Number not found");
            return Promise.reject('Account Number not found');
        }
        return Promise.resolve();
    });

}

Answer 6

It appears that the issue lies in your query. The find method operates asynchronously, causing the isfound property to not contain the expected data. To address this, I have implemented a straightforward solution using promises which has proven effective.

// Function to check if account number exists.
accountNumberExist(inputAcct) {
    return accounts.find({accountNumber: inputAcct})
    .then(result => {
        if (result.length == 0) {
            console.log("Account Number not found");
            return Promise.reject('Account Number not found');
        }
        return Promise.resolve();
    });

}

Ensuring the correctness of req.params using express validator

Answer №1

Answer №2

Answer №3

Similar questions

Utilizing ExpressJS for dynamic URL segments

Managing a multitude of instances in Three.js

Determining whether a user possesses a specific role

Keep your filter content up-to-date with real-time updates in Vue.js

The second div element remains unselected in jQuery

cdkDropList does not function properly when used with ng-template in a dynamic component list

Displaying list values as titles in a slider

Sort an array by mapping it in decreasing order based on the total sum of its elements

You've got a function floating around without any specific theme tied to it. Make sure one of the parent elements is utilizing a ThemeProvider for proper context

When attempting to delete a resource using an HTTP request in Insomnia, I encountered a TypeError stating that it was unable to read the property 'id'

Force restart broken socket within Node.js program using Socket.IO programmatically

Is verifying email and password with jquery possible?

Modifying data on the fly for a Highcharts series

Is the ID "nodeName" specifically designated as reserved in the HTML5 language specifications?

What is the best way to remove duplicate select options while keeping the selected option intact

What is the process for creating a MongoDB database on Heroku using MongoLab?

A guide on converting JSON without using the "&quot" symbol

When attempting to update a Vue data variable, an error occurred stating that "blogItems" is not defined

Example of material-ui-pickers: Error - Object(...) is not a function

Clearbox JS "notifications"