What is the best way to create a Scfilter that can effectively filter both string and number values?

Question

What is the best way to create a Scfilter that can effectively filter both string and number values?

Here is some Javascript (coffescript) code:

.filter "scFilter", () ->
  (collection, search) ->
    return collection unless search
    regexp = createAccentRegexp(search)
    doesMatch = (txt) -> (''+txt).match(regexp)
    collection.filter (el) ->
      if typeof el == 'object'
        return true for att, value of el when (typeof(value) === 'string' || typeof(value) === 'number') and doesMatch(value) and att !== '$$hashKey'
      else  
        doesMatch(el)

I am looking to modify the line "return true for att, value of el when typeof(value) is 'string' and doesMatch(value) and att isnt '$$hashKey'" so that it can filter both number and string values.

javascript angularjs coffeescript

Answer 1

Answer №1

If you want to improve the readability of your code, consider refining the conditional logic. Here are some alternative ways to express the condition within a loop:

return true for att, value of el when typeof(value) is 'string' and doesMatch(value) and att isnt '$$hashKey'

You could also achieve the same result with the following code:

for att, value of el
  return true if typeof(value) is 'string' and doesMatch(value) and att isnt '$$hashKey'

The syntax

doSomething() for X of/in Y when condition

can be used as a shorthand, but it's best suited for concise functions that fit on a single line.

To make the code more readable, you can skip over unwanted fields like this:

for att, value of el
  # filter out unwanted values
  continue unless typeof(value) is 'string'
  continue if att is '$$hashKey'
  # Check for matching search terms 
  return true if and doesMatch(value)

Expanding the search to include numbers is straightforward:

for att, value of el
  # filter out unwanted values
  continue unless typeof(value) in ['string', 'number']
  continue if att is '$$hashKey'
  # Check for matching search terms 
  return true if and doesMatch(value)

For more insights into CoffeeScript idioms and comprehensions, check out the little book of coffeescript, particularly the idioms section.

Answer 2

If you want to improve the readability of your code, consider refining the conditional logic. Here are some alternative ways to express the condition within a loop:

return true for att, value of el when typeof(value) is 'string' and doesMatch(value) and att isnt '$$hashKey'

You could also achieve the same result with the following code:

for att, value of el
  return true if typeof(value) is 'string' and doesMatch(value) and att isnt '$$hashKey'

The syntax

doSomething() for X of/in Y when condition

can be used as a shorthand, but it's best suited for concise functions that fit on a single line.

To make the code more readable, you can skip over unwanted fields like this:

for att, value of el
  # filter out unwanted values
  continue unless typeof(value) is 'string'
  continue if att is '$$hashKey'
  # Check for matching search terms 
  return true if and doesMatch(value)

Expanding the search to include numbers is straightforward:

for att, value of el
  # filter out unwanted values
  continue unless typeof(value) in ['string', 'number']
  continue if att is '$$hashKey'
  # Check for matching search terms 
  return true if and doesMatch(value)

For more insights into CoffeeScript idioms and comprehensions, check out the little book of coffeescript, particularly the idioms section.

What is the best way to create a Scfilter that can effectively filter both string and number values?

Answer №1

Similar questions

Why is my Navbar defaulting to be located inside the "./components/Index" folder?

The triggering of mouse events on 3D spheres in THREE.js does not occur accurately in the specified location

Customizing App (directory) elements in next.js 13

Using jQuery, upon the page loading, the script will automatically trigger a

What measures can be taken to ensure that the input checkbox is not toggled by accidentally pressing

Variations of a particular software package are necessary

Enabling client-side access to collections without the need for meteor startup

Maintain the values of the scope when transferring a template within ng-repeat

Executing Javascript within a Robot Framework test case can be achieved by using the Run Keyword

Guide on implementing a globalThis polyfill within a NextJS application

Manipulating specific elements within a MongoDB document's array using index values in a Node.js environment

Tips for updating views with asynchronous events in an Angular service or factory

What is the best method for determining the height of a sandboxed iframe?

The jQuery function triggers in the console upon first click but does not display in the browser. However, it shows up twice in the browser upon

jQuery request avoids encountering any 'Access-Control-Allow-Origin error

Adding an event listener to the built-in arrow buttons on the `<input type=number>` element is a simple way to enhance user interaction

Transferring data via AJAX technology

Ways to dynamically update the class name of pre-existing elements in React.js

Unable to set initial values for Select Option in Redux-Form

Exploring the use of $ in the outcome of a json for jQuery autocomplete functionality