Ways to set up an object's attributes or properties upon its creation through a method within a class

Question

Ways to set up an object's attributes or properties upon its creation through a method within a class

In my JavaScript code, I have a class called Bank that has a method "addBranch" which adds a Branch object to an array of branches. My goal is to set up a custom attribute "customers" for each Branch object as it gets added to the array.

Below is a simplified snippet of the code:

class Bank {
  #name
  #branches
  constructor(name) {
    this.#name = name
    this.#branches = []
  }

  // Name getter
  get name() {
    return this.#name
  }

  // Branches getter
  get branches() {
    return this.#branches
  }

  // Method to add branch
  addBranch(branch) {
    // Check if branch already exists
    if (this.#branches.includes(branch)) return false

    // Initialize customers attribute for the new branch
    branch.customers = []
    this.#branches.push(branch)
    console.log(`Pushed new branch: ${branch}`)
    return true
  }

I attempted to use "branch.customers = []" but encountered this error:

TypeError: Cannot create property 'customers' on string 'Branch1'. at Bank.addBranch (C:\Users\npdkh\Desktop\Integrify\fs17-week2-TS\src\bank.js:25:22). at Object. (C:\Users\npdkh\Desktop\Integrify\fs17-week2-TS\src\bank.js:85:6).

Node.js v18.17.1

javascript arrays class object attributes

Answer 1

Answer №1

Consider introducing an abstraction for the Branch and possibly even for the Customer. However, it is not mandatory to take that approach. The decision depends on when one wants to handle all the object states involved. An alternative could be passing simple object types with unprotected properties.

By opting for another abstraction, the original task of adding a customers property to the branch value/object can be alleviated.

It is also important to reconsider how comparisons between added branches and customers are conducted. The example code provided below only compares the name properties for similarity, which might be considered a limited form of comparison. This method can be extended based on requirements.

class Branch {
  #name;
  #customers = [];

  constructor(name) {
    this.#name = name;
  }

  get name() {
    return this.#name;
  }
  get customers() {
    return this.#customers.map(customer => customer.valueOf());
  }
  valueOf() {
    return {
      name: this.name,
      customers: this.customers,
    };
  }

  addCustomer(customer) {
    let success = false;

    const customerName = customer.name;
    const match = this.#customers.find(({ name }) => name === customerName);

    if (!match) {
      success = true;

      this.#customers.push(customer);

      console.log('... newly added customer ...', customer.valueOf());
    }
    return success;
  }
}

class Bank {
  #name;
  #branches = [];

  constructor(name) {
    this.#name = name;
  }

  get name() {
    return this.#name;
  }
  get branches() {
    return this.#branches.map(branch => branch.valueOf());
  }
  valueOf() {
    return {
      name: this.name,
      branches: this.branches,
    };
  }

  addBranch(branch) {
    let success = false;

    const branchName = branch.name;
    const match = this.#branches.find(({ name }) => name === branchName);

    if (!match) {
      success = true;

      this.#branches.push(branch);

      console.log('... newly added branch ...', branch.valueOf());
    }
    return success;
  }
}

const bank = new Bank('A Bank');

console.log({
  bank: bank.valueOf(),
});
bank.addBranch(new Branch('A Branch'));

console.log({
  bank: bank.valueOf(),
});

.as-console-wrapper { min-height: 100%!important; top: 0; }

Answer 2

Consider introducing an abstraction for the Branch and possibly even for the Customer. However, it is not mandatory to take that approach. The decision depends on when one wants to handle all the object states involved. An alternative could be passing simple object types with unprotected properties.

By opting for another abstraction, the original task of adding a customers property to the branch value/object can be alleviated.

It is also important to reconsider how comparisons between added branches and customers are conducted. The example code provided below only compares the name properties for similarity, which might be considered a limited form of comparison. This method can be extended based on requirements.

class Branch {
  #name;
  #customers = [];

  constructor(name) {
    this.#name = name;
  }

  get name() {
    return this.#name;
  }
  get customers() {
    return this.#customers.map(customer => customer.valueOf());
  }
  valueOf() {
    return {
      name: this.name,
      customers: this.customers,
    };
  }

  addCustomer(customer) {
    let success = false;

    const customerName = customer.name;
    const match = this.#customers.find(({ name }) => name === customerName);

    if (!match) {
      success = true;

      this.#customers.push(customer);

      console.log('... newly added customer ...', customer.valueOf());
    }
    return success;
  }
}

class Bank {
  #name;
  #branches = [];

  constructor(name) {
    this.#name = name;
  }

  get name() {
    return this.#name;
  }
  get branches() {
    return this.#branches.map(branch => branch.valueOf());
  }
  valueOf() {
    return {
      name: this.name,
      branches: this.branches,
    };
  }

  addBranch(branch) {
    let success = false;

    const branchName = branch.name;
    const match = this.#branches.find(({ name }) => name === branchName);

    if (!match) {
      success = true;

      this.#branches.push(branch);

      console.log('... newly added branch ...', branch.valueOf());
    }
    return success;
  }
}

const bank = new Bank('A Bank');

console.log({
  bank: bank.valueOf(),
});
bank.addBranch(new Branch('A Branch'));

console.log({
  bank: bank.valueOf(),
});

.as-console-wrapper { min-height: 100%!important; top: 0; }

Answer 3

Answer №2

let newBranch = new Branch('Primary Branch'); let myBank = new Bank('Best Bank');

myBank.addBranch(newBranch); console.log(newBranch.customers); // prints: []

Answer 4

let newBranch = new Branch('Primary Branch'); let myBank = new Bank('Best Bank');

myBank.addBranch(newBranch); console.log(newBranch.customers); // prints: []

Ways to set up an object's attributes or properties upon its creation through a method within a class

Answer №1

Answer №2

Similar questions

What is the proper way to implement React's Link component from an external npm package to avoid the error message stating, "you should not use link outside router"?

Dealing with the Back Button Problem in History API and History.js

Issue with data set

What is the best way to invoke a single ajax function across multiple pages with varying URLs?

the sequence of events in a web setting

Obtaining a value from HTML and passing it to another component in Angular

What is the best way to implement a scroll to top/bottom button globally in Vue?

Updating ng-init in AngularJS triggered by a changeOR Changing

Is there a way to smoothly navigate back to the top of the page after the fragment identifier causes the page to scroll down?

Using pointer arrays of characters in the C programming language

The URL being called by $http.get is incorrect

Should the index.js file in Next.js serve as the homepage or solely as the initial starting point?

Having trouble with charts not appearing on your Django website?

I aimed to find the first day of the month, but my calculation led me to the last day instead

Utilizing useRef with React Three in App component results in null value for threejs entities

Sending a list via Ajax in Django

Transforming Image Annotation from Angular 1 to Angular 4: Overcoming Conversion Challenges and Comparing Equivalents from 1.x to 4

React not displaying wrapped div

Working with a character array as the file name in C using the fopen() function

Discovering the technique to dynamically load various content using jQuery in a div based on its