Unfulfilled commitment on bcrypt

Question

Unfulfilled commitment on bcrypt

I am currently facing an issue while trying to validate a user's password using bcryptjs. I have implemented a function that returns a Promise, but I am encountering an error when reaching the bycrypt.hash step - all I see is Promise { <pending> }, which means that .then() will not execute correctly. I have been struggling with this problem for some time now and would greatly appreciate any help.

userSchema.methods.verifyPassword = function (password, err, next) {
  const saltSecret = this.saltSecret;
  const a = async function(resolve, reject) {
    console.log('hi4')
    console.log('this.saltSecret2', saltSecret);
    console.log(password);

    const hashed_pass = await bcrypt.hash(password, saltSecret);
    console.log('hash', hashed_pass);
    const valid = await bcrypt.compare(password, hashed_pass);
    if(valid){
      console.log('GOOD');
    }
  };
  a();
};

javascript express bcrypt

Answer 1

Answer №1

When it comes to handling promises, I prefer using async-await syntax. Not only is it less confusing, but it also makes it easier to quickly understand someone else's code.

You can turn your function into an async one and await for bcrypt to complete its task.

const password = await bcrypt.hash(password, saltSecret);

Additionally, the bcrypt library offers a function to compare passwords with their hashed counterparts.

const valid = await bcrypt.compare(password, hashed_pass);

Give this code a try:

async function(resolve, reject) {
  console.log('hi4')
  console.log(this.saltSecret);
  console.log(password);

  const hashed_pass = await bcrypt.hash(password, saltSecret);
  console.log('hash', hashed_pass);
  const valid = await bcrypt.compare(password, hashed_pass);
  if(valid){
    console.log('GOOD');
  }
};

Answer 2

When it comes to handling promises, I prefer using async-await syntax. Not only is it less confusing, but it also makes it easier to quickly understand someone else's code.

You can turn your function into an async one and await for bcrypt to complete its task.

const password = await bcrypt.hash(password, saltSecret);

Additionally, the bcrypt library offers a function to compare passwords with their hashed counterparts.

const valid = await bcrypt.compare(password, hashed_pass);

Give this code a try:

async function(resolve, reject) {
  console.log('hi4')
  console.log(this.saltSecret);
  console.log(password);

  const hashed_pass = await bcrypt.hash(password, saltSecret);
  console.log('hash', hashed_pass);
  const valid = await bcrypt.compare(password, hashed_pass);
  if(valid){
    console.log('GOOD');
  }
};

Answer 3

Answer №2

Whenever you use this code snippet, it will result in a Promise.

console.log(bcrypt.hash(password, this.saltSecret));

One possible approach to handle this situation is demonstrated below.

return new Promise(async (resolve, reject) => {
    const hash = await bcrypt.hash(password, this.saltSecret);

    if (hash === this.password) {
        return resolve(true);
    }

    return reject();
});

Answer 4

Whenever you use this code snippet, it will result in a Promise.

console.log(bcrypt.hash(password, this.saltSecret));

One possible approach to handle this situation is demonstrated below.

return new Promise(async (resolve, reject) => {
    const hash = await bcrypt.hash(password, this.saltSecret);

    if (hash === this.password) {
        return resolve(true);
    }

    return reject();
});

Answer 5

Answer №3

bcrypt.hash utilizes a callback function instead of a promise (which is why it uses .then)

The correct way to use it is as follows:

bcrypt.hash(password, this.saltSecret, (err, hash) => {
    ...
});

Answer 6

bcrypt.hash utilizes a callback function instead of a promise (which is why it uses .then)

The correct way to use it is as follows:

bcrypt.hash(password, this.saltSecret, (err, hash) => {
    ...
});

Answer 7

Answer №4

How to Encapsulate in a Promise

const createHashedPassword = async (
      passwordToHash: string,
      roundsOfSalt = 10
    ): Promise<{
      salt: string;
      hash: string;
    }> => {
      return new Promise((resolve, reject) => {
        try {
          const salt = bcrypt.genSaltSync(roundsOfSalt);
          return bcrypt.hash(passwordToHash, salt, (error, hash) => {
            if (error) {
              reject(error);
            } else {
              resolve({
                salt,
                hash,
              });
            }
          });
        } catch (err) {
          console.error(err);
          throw err;
        }
      });
    };

Answer 8

How to Encapsulate in a Promise

const createHashedPassword = async (
      passwordToHash: string,
      roundsOfSalt = 10
    ): Promise<{
      salt: string;
      hash: string;
    }> => {
      return new Promise((resolve, reject) => {
        try {
          const salt = bcrypt.genSaltSync(roundsOfSalt);
          return bcrypt.hash(passwordToHash, salt, (error, hash) => {
            if (error) {
              reject(error);
            } else {
              resolve({
                salt,
                hash,
              });
            }
          });
        } catch (err) {
          console.error(err);
          throw err;
        }
      });
    };

Unfulfilled commitment on bcrypt

Answer №1

Answer №2

Answer №3

Answer №4

Similar questions

Encountering an issue with accessing properties of undefined while trying to post to mongoose with the 'name' field

What causes my absolutely positioned element to disappear when using overflow-x: hidden?

Looking for help combining HTML5 Canvas and JavaScript to showcase images. Can anyone lend a hand?

Mongoose parameters do not accept passing an id or element

Is it possible to incorporate Nth child into JavaScript?

Unusual Glitch in Bootstrap 3 Dropdown Menu

What is an alternative method to retrieve form data without relying on bodyParser?

Microphone Malfunction: Abrupt End of Input Detected

Using AngularJs to implement a $watch feature that enables two-way binding

Creating a mouseover popup window for a specific text citation based on its ID using JavaScript in XSLT

Journey Through Routes with ES6 Classes

Achieving successful functionality with position:relative in IE9

Error in delete operation due to CORS in Flask API

Guide to adding a checkbox to a JavaScript list

How can JavaScript be used to access response header information in Devise Token Auth?

Parsing PHP array using JavaScript

File download is initiated through an Ajax response

Is it possible to activate events on select tags even when they have the disabled attribute?

Tips on creating an onclick function in javaScript and linking it to innerHTML

The Chart.js donut chart is not displaying as expected on the HTML page when using