Unfulfilled commitment on bcrypt

Question

Unfulfilled commitment on bcrypt

I am currently facing an issue while trying to validate a user's password using bcryptjs. I have implemented a function that returns a Promise, but I am encountering an error when reaching the bycrypt.hash step - all I see is Promise { <pending> }, which means that .then() will not execute correctly. I have been struggling with this problem for some time now and would greatly appreciate any help.

userSchema.methods.verifyPassword = function (password, err, next) {
  const saltSecret = this.saltSecret;
  const a = async function(resolve, reject) {
    console.log('hi4')
    console.log('this.saltSecret2', saltSecret);
    console.log(password);

    const hashed_pass = await bcrypt.hash(password, saltSecret);
    console.log('hash', hashed_pass);
    const valid = await bcrypt.compare(password, hashed_pass);
    if(valid){
      console.log('GOOD');
    }
  };
  a();
};

javascript express bcrypt

Answer 1

Answer №1

When it comes to handling promises, I prefer using async-await syntax. Not only is it less confusing, but it also makes it easier to quickly understand someone else's code.

You can turn your function into an async one and await for bcrypt to complete its task.

const password = await bcrypt.hash(password, saltSecret);

Additionally, the bcrypt library offers a function to compare passwords with their hashed counterparts.

const valid = await bcrypt.compare(password, hashed_pass);

Give this code a try:

async function(resolve, reject) {
  console.log('hi4')
  console.log(this.saltSecret);
  console.log(password);

  const hashed_pass = await bcrypt.hash(password, saltSecret);
  console.log('hash', hashed_pass);
  const valid = await bcrypt.compare(password, hashed_pass);
  if(valid){
    console.log('GOOD');
  }
};

Answer 2

When it comes to handling promises, I prefer using async-await syntax. Not only is it less confusing, but it also makes it easier to quickly understand someone else's code.

You can turn your function into an async one and await for bcrypt to complete its task.

const password = await bcrypt.hash(password, saltSecret);

Additionally, the bcrypt library offers a function to compare passwords with their hashed counterparts.

const valid = await bcrypt.compare(password, hashed_pass);

Give this code a try:

async function(resolve, reject) {
  console.log('hi4')
  console.log(this.saltSecret);
  console.log(password);

  const hashed_pass = await bcrypt.hash(password, saltSecret);
  console.log('hash', hashed_pass);
  const valid = await bcrypt.compare(password, hashed_pass);
  if(valid){
    console.log('GOOD');
  }
};

Answer 3

Answer №2

Whenever you use this code snippet, it will result in a Promise.

console.log(bcrypt.hash(password, this.saltSecret));

One possible approach to handle this situation is demonstrated below.

return new Promise(async (resolve, reject) => {
    const hash = await bcrypt.hash(password, this.saltSecret);

    if (hash === this.password) {
        return resolve(true);
    }

    return reject();
});

Answer 4

Whenever you use this code snippet, it will result in a Promise.

console.log(bcrypt.hash(password, this.saltSecret));

One possible approach to handle this situation is demonstrated below.

return new Promise(async (resolve, reject) => {
    const hash = await bcrypt.hash(password, this.saltSecret);

    if (hash === this.password) {
        return resolve(true);
    }

    return reject();
});

Answer 5

Answer №3

bcrypt.hash utilizes a callback function instead of a promise (which is why it uses .then)

The correct way to use it is as follows:

bcrypt.hash(password, this.saltSecret, (err, hash) => {
    ...
});

Answer 6

bcrypt.hash utilizes a callback function instead of a promise (which is why it uses .then)

The correct way to use it is as follows:

bcrypt.hash(password, this.saltSecret, (err, hash) => {
    ...
});

Answer 7

Answer №4

How to Encapsulate in a Promise

const createHashedPassword = async (
      passwordToHash: string,
      roundsOfSalt = 10
    ): Promise<{
      salt: string;
      hash: string;
    }> => {
      return new Promise((resolve, reject) => {
        try {
          const salt = bcrypt.genSaltSync(roundsOfSalt);
          return bcrypt.hash(passwordToHash, salt, (error, hash) => {
            if (error) {
              reject(error);
            } else {
              resolve({
                salt,
                hash,
              });
            }
          });
        } catch (err) {
          console.error(err);
          throw err;
        }
      });
    };

Answer 8

How to Encapsulate in a Promise

const createHashedPassword = async (
      passwordToHash: string,
      roundsOfSalt = 10
    ): Promise<{
      salt: string;
      hash: string;
    }> => {
      return new Promise((resolve, reject) => {
        try {
          const salt = bcrypt.genSaltSync(roundsOfSalt);
          return bcrypt.hash(passwordToHash, salt, (error, hash) => {
            if (error) {
              reject(error);
            } else {
              resolve({
                salt,
                hash,
              });
            }
          });
        } catch (err) {
          console.error(err);
          throw err;
        }
      });
    };

Unfulfilled commitment on bcrypt

Answer №1

Answer №2

Answer №3

Answer №4

Similar questions

JavaScript/CSS manipulation: The power of overriding animation-fill-mode

Is it possible for a Node.js/Express server to securely handle all UTF-8 characters?

Focus Google Map on Selected Option using AngularJS

Adjusting the appearance of a JavaScript element based on its hierarchy level

Using NodeJS to establish a DB2 connection pooling system for an Express application

Angular5+ Error: Unable to retrieve summary for RouterOutlet directive due to illegal state

Dockerhub build process encountering errors with npm install bcrypt causing automated build to fail

Guide for displaying retrieved information on a Bootstrap Modal window following data submission in Yii2

The function signature '(_event: React.SyntheticEvent, value: number) => void' cannot be assigned to the type 'FormEventHandler<HTMLUListElement>'

Is it necessary to decode the JSON data stored in the variable?

What are some strategies for optimizing React performance when managing controlled input from numerous components?

Is it possible to determine whether a path leads to a directory or a file?

Finding the measurement of a sofa using couch.get(data, headers, status)

Dynamic Bootstrap Modal Widget

Nextjs unexpectedly displays blank page upon fetching data from Firebase Firestore without any error messages

After the initial rendering, JQuery can dynamically search through the DOM elements and seamlessly replace keys with their respective values

Utilizing the array result obtained from the fetch function

Discovering the function invoker when in strict mode

Is there a way to retrieve the chosen selection from a select dropdown element using JavaScript?

In-line Vertical Ticker Display