Tips for creating a concise switch statement in JavaScript, incorporating both the use of Express and Mongoose

Question

Tips for creating a concise switch statement in JavaScript, incorporating both the use of Express and Mongoose

Here's the current situation:

I am tasked with searching in 3 different databases for an ID associated with a shift. Each shift is classified as either an Activity, Food and Beverages, or Other type.

When making the search, the type is provided in the request body.

To handle this, I am using a switch statement to determine which database to search through.

switch(type_shift){
     case("activity"):
     response = await ActivityShiftDB.findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();
     break;

     case("fandb"):
     response = await FoodBeveragesShiftDB.findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();
     break;

     case("other"):
     response = await OtherShiftDB.findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();
     break;
   }

However, I feel like this code is not very DRY (Don't Repeat Yourself). Is there a better approach to handling this situation?

javascript mongodb express mongoose

Answer 1

Answer №1

Rearrange the code structure to improve readability:

let shiftDB;
switch (type_shift) {
    case "activity":
        shiftDB = ActivityShiftDB;
        break;
    case "fandb":
        shiftDB = FoodBeveragesShiftDB;
        break;
    case "other":
        shiftDB = OtherShiftDB;
        break;
    default:
        throw new Error("unknown type_shift");
}
response = await shiftDB.findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();

Consider a more concise approach without using a switch statement:

const shiftDBsByType = {
    "activity": ActivityShiftDB,
    "fandb": FoodBeveragesShiftDB,
    "other": OtherShiftDB,
}
if (!(type_shift in shiftDBsByType)) {
    throw new Error("unknown type_shift");
}
response = await shiftDBsByType[type_shift].findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();

Answer 2

Rearrange the code structure to improve readability:

let shiftDB;
switch (type_shift) {
    case "activity":
        shiftDB = ActivityShiftDB;
        break;
    case "fandb":
        shiftDB = FoodBeveragesShiftDB;
        break;
    case "other":
        shiftDB = OtherShiftDB;
        break;
    default:
        throw new Error("unknown type_shift");
}
response = await shiftDB.findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();

Consider a more concise approach without using a switch statement:

const shiftDBsByType = {
    "activity": ActivityShiftDB,
    "fandb": FoodBeveragesShiftDB,
    "other": OtherShiftDB,
}
if (!(type_shift in shiftDBsByType)) {
    throw new Error("unknown type_shift");
}
response = await shiftDBsByType[type_shift].findByIdAndUpdate(id_shift, {$pull : {"support": user}}).exec();

Tips for creating a concise switch statement in JavaScript, incorporating both the use of Express and Mongoose

Answer №1

Similar questions

Prevent user input in Vue.js until the value has been modified

What sets Import apart from require in TypeScript?

The Response body was abruptly cut off due to an unexpected JSON input error, which falls under the category of self

A see-through object appears only properly when viewed from one specific angle

ReactJS: Dealing with issues in setting a dynamic index for the setState key

Discovering ways to align specific attributes of objects or target specific components within arrays

Guide to modifying the class color using javascript

Collapse an array containing objects with nested objects inside

Using Sinonjs fakeserver to handle numerous ajax requests

How can I incorporate dynamic data to draw and showcase graphs on my website using PHP?

Adjust the overall size of the CSS baseball field

When a project sets useBuiltIns to 'usage', there is an issue with importing the library generated by Webpack

RS256 requires that the secretOrPrivateKey is an asymmetric key

Two users are attempting to book two different appointments at the same time in Node.js utilizing MongoDB. However, only one user will

Exploring the Possibilities: Incorporating xlsx Files in Angular 5

Running SOAP services with Jasmine framework in Node.js: A step-by-step guide

Creating a form in PHP with the power of JavaScript, AJAX, and jQuery

Button react-native press following textInput within scroll view aware of keyboard movements

Getting information from a JSON file with several variables: A guide for using node.js, express, and jQuery

Obtain information from local server in a React Native application