The while loop is unyielding, persisting beyond the realm of

Question

The while loop is unyielding, persisting beyond the realm of

After executing this script, it displays the HP values for both Pokemon. Pressing 1 and pressing enter subtracts your attack points from the enemy's hit points. The goal is to stop the battle when either you or the enemy reaches 0 or below hit points and then display the winner in the console log. However, there seems to be a bug where an extra hit is required for the message to show up if you are at -10 HP.

For example, if you are at -10 HP, an additional hit is needed before the victory message appears.

let firstFight = false;

while (!firstFight) {
  let fightOptions = prompt("1. Fight, 2.Items, 3.Potions " + wildPokemon[0].name + ":" + wildPokemon[0].hp + " " + pokeBox[0].name + ":" + pokeBox[0].hp);
  if (fightOptions == 1) {

    if (!firstFight) {

      if (wildPokemon[0].hp <= 0) {
        console.log("You have won!");
        firstFight = true;
      } else {
        let attack1 = wildPokemon[0].hp -= pokeBox[0].attack.hp;
        console.log(wildPokemon[0].hp);
      }

      if (pokeBox[0].hp <= 0) {
        console.log(wildPokemon[0] + " has killed you");
        firstFight = true;
      } else {
        let attack2 = pokeBox[0].hp -= wildPokemon[0].attack.hp;
        console.log(pokeBox[0].hp);
      }
    }

  } else if (fightOptions == 2) {

  } else if (fightOptions == 3) {

  } else {

  }

}

Are there any suggestions on how to enhance the efficiency of this code?

javascript if-statement while-loop console prompt

Answer 1

Answer №1

One way to streamline the code is by adding an additional if condition to check the player's life within the same turn instead of waiting for the next turn.

This approach eliminates the need for extra conditional statements and makes the logic more concise.

    if (fightOptions == 1) {

       let attack1 = wildPokemon[0].hp -= pokeBox[0].attack.hp;
       console.log(wildPokemon[0].hp);
       if (wildPokemon[0].hp <= 0) {
          console.log("You have won!");
          firstFight = true;
       }

      if (!firstFight){
         let attack2 = pokeBox[0].hp -= wildPokemon[0].attack.hp;
         console.log(pokeBox[0].hp);
         if (pokeBox[0].hp <= 0) {
            console.log(wildPokemon[0] + " has killed you");
            firstFight = true;
         }
      }

   }

Answer 2

One way to streamline the code is by adding an additional if condition to check the player's life within the same turn instead of waiting for the next turn.

This approach eliminates the need for extra conditional statements and makes the logic more concise.

    if (fightOptions == 1) {

       let attack1 = wildPokemon[0].hp -= pokeBox[0].attack.hp;
       console.log(wildPokemon[0].hp);
       if (wildPokemon[0].hp <= 0) {
          console.log("You have won!");
          firstFight = true;
       }

      if (!firstFight){
         let attack2 = pokeBox[0].hp -= wildPokemon[0].attack.hp;
         console.log(pokeBox[0].hp);
         if (pokeBox[0].hp <= 0) {
            console.log(wildPokemon[0] + " has killed you");
            firstFight = true;
         }
      }

   }

Answer 3

Answer №2

The issue arises when the points are deducted after verifying if they are less than or equal to zero. A better approach would be to check beforehand like this:

let initialBattle = false;

while (!initialBattle) {
  let battleOptions = prompt("1. Fight, 2.Items, 3.Potions " + wildPokemon[0].name + ":" + wildPokemon[0].hp + " " + pokeBox[0].name + ":" + pokeBox[0].hp);
  if (battleOptions == 1) {
    wildPokemon[0].hp -= pokeBox[0].attack.hp;

    if (wildPokemon[0].hp <= 0) {
      console.log("Congratulations! You have emerged victorious!");
      initialBattle = true;
    } else {
      console.log(wildPokemon[0].hp);
    }

    pokeBox[0].hp -= wildPokemon[0].attack.hp;
    if (!initialBattle && pokeBox[0].hp <= 0) {
      console.log(wildPokemon[0] + " has defeated you");
      initialBattle = true;
    } else {
      console.log(pokeBox[0].hp);
    }
  } else if (battleOptions == 2) {

   } else if (battleOptions == 3) {

   } else {

   }
}

Answer 4

The issue arises when the points are deducted after verifying if they are less than or equal to zero. A better approach would be to check beforehand like this:

let initialBattle = false;

while (!initialBattle) {
  let battleOptions = prompt("1. Fight, 2.Items, 3.Potions " + wildPokemon[0].name + ":" + wildPokemon[0].hp + " " + pokeBox[0].name + ":" + pokeBox[0].hp);
  if (battleOptions == 1) {
    wildPokemon[0].hp -= pokeBox[0].attack.hp;

    if (wildPokemon[0].hp <= 0) {
      console.log("Congratulations! You have emerged victorious!");
      initialBattle = true;
    } else {
      console.log(wildPokemon[0].hp);
    }

    pokeBox[0].hp -= wildPokemon[0].attack.hp;
    if (!initialBattle && pokeBox[0].hp <= 0) {
      console.log(wildPokemon[0] + " has defeated you");
      initialBattle = true;
    } else {
      console.log(pokeBox[0].hp);
    }
  } else if (battleOptions == 2) {

   } else if (battleOptions == 3) {

   } else {

   }
}

Answer 5

Answer №3

When a while loop stops depends on the condition being false. In your specific case, the loop is not stopping because you have not explicitly defined when it should stop. There are two ways to address this:

1st Approach:

while(!firstFight == false)

2nd Approach:

var firstFight = true; while(firstFight) then set the firstFight to false within your if else statements.

Answer 6

When a while loop stops depends on the condition being false. In your specific case, the loop is not stopping because you have not explicitly defined when it should stop. There are two ways to address this:

1st Approach:

while(!firstFight == false)

2nd Approach:

var firstFight = true; while(firstFight) then set the firstFight to false within your if else statements.

The while loop is unyielding, persisting beyond the realm of

Answer №1

Answer №2

Answer №3

Similar questions

The powerful combination of Nuxt, Vuex, and Computed Properties allows for

"Fill the designated area on the webpage with data retrieved from an external script

In Typescript with Vue.JS, the type 'Users[]' does not include the essential properties of type 'ArrayConstructor' such as isArray, prototype, from, of, and [Symbol.species]

Dealing with multiple ajax requests while utilizing a single fail callback

How to use image blob in Angular JS?

Merging two arrays concurrently in Angular 7

Navigating JSON data with unexpected fields in Typescript and React.js

Tips for setting up a typeorm entity with attention to its nullable fields

What is the limitation in transmitting data as a JavaScript object rather than a JSON object?

Ways to incorporate vector .svg images into a D3js tree diagram

Refreshing RadioGroup selection in React.js

What are the best techniques for maintaining state in Xstate state machines within a React application?

What sets Gulp-Browserify apart from regular Browserify?

What tool can be used for formatting and syntax highlighting when working with ejs (embedded javascript) templates?

Utilizing ReactJS useState to eliminate a className

I would greatly appreciate some guidance on asp.net and javascript

Stop the Sidebar from showing up on certain pages with Next.js

Is it possible to close the menu by clicking outside a div or letting it disappear on mouseout after a set period of time?

Using jQuery idle timeout to abort jQuery AJAX calls in Laravel 5.2

My locale NUXT JavaScript files are being blocked by Content Security Policy