The nested for loop that I am using is producing repeated values

Question

The nested for loop that I am using is producing repeated values

The objective of this operation is to input:

[{lang: 'English', proficiency: 'Elementary Proficiency'}, {lang: 'Spanish', proficiency: 'Full Professional Proficiency'}]

.

Then, the goal is to output:

[{level: 1, lang: 'English', proficiency: 'Elementary Proficiency'}, { level:3, lang: 'Spanish', proficiency: 'Full Professional Proficiency'}]

.

However, the current output is:

[{level:3, lang: 'Spanish', proficiency: 'Full Professional Proficiency}, {level:3, lang: 'Spanish', proficiency: 'Full Professional Proficiency}]

. Any suggestions? Thank you.

updateSort(exObj) {
      let userprof = []
      let lng = []

      const proficiencies = [
        { level: 1, name: 'Elementary Proficiency' },
        { level: 2, name: 'Limited Working Proficiency' },
        { level: 3, name: 'Full Professional Proficiency' },
        { level: 4, name: 'Native Bilingual Proficiency' }
      ]

      for(let v in exObj) {
        userprof.push(exObj[v].proficiency);
        lng.push(exObj[v].lang);
      }

      let findMaxProficiency = (proficiencies, userprof) => {
          const arr = [];
          const ob = {};

          let found = false;
          for (const prof of proficiencies) {
            for (const user of userprof) {
              if (found) found = false
              for (const l of lng) {
                if (prof.name === user) {
                  ob.level = qual.level
                  ob.proficiency = qual.name
                  ob.lang = l
                  arr.push(ob);
                  found = true
                  break
                }
              }
            }
          }
          console.log("PROFICIENCIES FOUND: " + JSON.stringify(arr))
      }
      findMaxProficiency(proficiencies, userqual);
    }

javascript for-loop nested

Answer 1

Answer №1

It seems that utilizing the map function provides a more straightforward solution to this problem.

const levels = [
  { number: 1, type: 'Basic Level' },
  { number: 2, type: 'Intermediate Level' },
  { number: 3, type: 'Advanced Level' },
  { number: 4, type: 'Expert Level' }
];

const languages = [
  { name: 'English', level: 'Basic Level' },
  { name: 'Spanish', level: 'Advanced Level' }
];


const result = languages.map((language) => {
  const proficiencyLevel = levels.find(l => l.type === language.level);
  if (proficiencyLevel) {
    language.number = proficiencyLevel.number;
  }
  return language;
});

console.log(result);

Answer 2

It seems that utilizing the map function provides a more straightforward solution to this problem.

const levels = [
  { number: 1, type: 'Basic Level' },
  { number: 2, type: 'Intermediate Level' },
  { number: 3, type: 'Advanced Level' },
  { number: 4, type: 'Expert Level' }
];

const languages = [
  { name: 'English', level: 'Basic Level' },
  { name: 'Spanish', level: 'Advanced Level' }
];


const result = languages.map((language) => {
  const proficiencyLevel = levels.find(l => l.type === language.level);
  if (proficiencyLevel) {
    language.number = proficiencyLevel.number;
  }
  return language;
});

console.log(result);

Answer 3

Answer №2

To successfully break out of all levels of the for loop, make sure to include additional break statements. If you only break out of the deepest level, the next loop will not exit and will start over. This can lead to unintended behavior where your boolean variable gets reset with the instruction if (found) found = false, causing the same tasks to be repeated.

for (const prof of proficiencies) {
    for (const user of userprof) {
        if (found) found = false
        for (const l of lng) {
            if (prof.name === user) {
                ob.level = qual.level
                ob.proficiency = qual.name
                ob.lang = l
                arr.push(ob);
                found = true
                break
            }
        }
        if (found) break;
    }
    if (found) break;
}

Answer 4

To successfully break out of all levels of the for loop, make sure to include additional break statements. If you only break out of the deepest level, the next loop will not exit and will start over. This can lead to unintended behavior where your boolean variable gets reset with the instruction if (found) found = false, causing the same tasks to be repeated.

for (const prof of proficiencies) {
    for (const user of userprof) {
        if (found) found = false
        for (const l of lng) {
            if (prof.name === user) {
                ob.level = qual.level
                ob.proficiency = qual.name
                ob.lang = l
                arr.push(ob);
                found = true
                break
            }
        }
        if (found) break;
    }
    if (found) break;
}

Answer 5

Answer №3

By converting your skills array into an object, you can simplify the process using just one map() function.

const input = [{language: 'French', proficiency: 'Intermediate Proficiency'}, {language: 'German', proficiency: 'Advanced Proficiency'}];

const proficiencies = {
        'Elementary Proficiency': 1,
        'Limited Working Proficiency': 2,
        'Full Professional Proficiency': 3, 
        'Native Bilingual Proficiency': 4
      }

const result = input.map(obj => ({level: proficiencies[obj.proficiency],...obj}));

console.log(result);

Answer 6

By converting your skills array into an object, you can simplify the process using just one map() function.

const input = [{language: 'French', proficiency: 'Intermediate Proficiency'}, {language: 'German', proficiency: 'Advanced Proficiency'}];

const proficiencies = {
        'Elementary Proficiency': 1,
        'Limited Working Proficiency': 2,
        'Full Professional Proficiency': 3, 
        'Native Bilingual Proficiency': 4
      }

const result = input.map(obj => ({level: proficiencies[obj.proficiency],...obj}));

console.log(result);

Answer 7

Answer №4

If you're looking for a simpler solution to your issue, consider approaching it from a different angle. Instead of using multiple loops, you can utilize a Map structure (similar to an object with key-value pairs accessible via .get(key)). Construct the map from the proficiency array by employing the Map constructor. This constructor requires an array of

[[key1, value1], [key2, value2], ...]

pairs that can be created using the .map() method on your array. The resulting map will resemble this:

"Elementary Proficiency" => 1
"Limited Working Proficiency" => 2
"Full Professional Proficiency" => 3
"Native Bilingual Proficiency" => 4

The numbers represent values obtainable from the map using .get(proficiencyName). Once established, simply update all objects in your original array to include a level property. Achieve this by utilizing .map() again to construct new objects with current properties (employing the spread syntax ...), along with an additional level property obtained by referencing the proficiency level in the Map created earlier:

const arr = [{lang: 'English', proficiency: 'Elementary Proficiency'}, {lang: 'Spanish', proficiency: 'Full Professional Proficiency'}];
const proficiencies = [ { level: 1, name: 'Elementary Proficiency' }, { level: 2, name: 'Limited Working Proficiency' }, { level: 3, name: 'Full Professional Proficiency' }, { level: 4, name: 'Native Bilingual Proficiency' } ];

const levelLookUp = new Map(proficiencies.map(o => [o.name, o.level]));
const result = arr.map(obj => ({level: levelLookUp.get(obj.proficiency), ...obj}));

console.log(result);

Creating a Map first enhances performance, especially with larger input arrays, as it involves looping over the proficiencies array and the input array independently only once, avoiding potential performance issues associated with nested loops.

Answer 8

If you're looking for a simpler solution to your issue, consider approaching it from a different angle. Instead of using multiple loops, you can utilize a Map structure (similar to an object with key-value pairs accessible via .get(key)). Construct the map from the proficiency array by employing the Map constructor. This constructor requires an array of

[[key1, value1], [key2, value2], ...]

pairs that can be created using the .map() method on your array. The resulting map will resemble this:

"Elementary Proficiency" => 1
"Limited Working Proficiency" => 2
"Full Professional Proficiency" => 3
"Native Bilingual Proficiency" => 4

The numbers represent values obtainable from the map using .get(proficiencyName). Once established, simply update all objects in your original array to include a level property. Achieve this by utilizing .map() again to construct new objects with current properties (employing the spread syntax ...), along with an additional level property obtained by referencing the proficiency level in the Map created earlier:

const arr = [{lang: 'English', proficiency: 'Elementary Proficiency'}, {lang: 'Spanish', proficiency: 'Full Professional Proficiency'}];
const proficiencies = [ { level: 1, name: 'Elementary Proficiency' }, { level: 2, name: 'Limited Working Proficiency' }, { level: 3, name: 'Full Professional Proficiency' }, { level: 4, name: 'Native Bilingual Proficiency' } ];

const levelLookUp = new Map(proficiencies.map(o => [o.name, o.level]));
const result = arr.map(obj => ({level: levelLookUp.get(obj.proficiency), ...obj}));

console.log(result);

Creating a Map first enhances performance, especially with larger input arrays, as it involves looping over the proficiencies array and the input array independently only once, avoiding potential performance issues associated with nested loops.

The nested for loop that I am using is producing repeated values

Answer №1

Answer №2

Answer №3

Answer №4

Similar questions

What is the best way to send a string and a component as a prop?

jQuery document.ready function not triggering as expected (even with jQuery included)

Obtaining template attributes in CKEditor: A guide

Are there any AJAX tools or packages in Node.js Express for connecting (posting/getting) with other servers and retrieving data?

Enhance a React component by including additional properties when passing it into another component through props

Change a 24-hour time variable to 12-hour time using AngularJS/jQuery technology

Learn how to execute JavaScript code in Selenium without launching a web browser

What is the best way to incorporate a table name into a MySQL query using ExpressJs?

Issue with AJAX causing form data not to be passed to controller

Leveraging react props with the .map method

What is the best way to execute createReadStream(a stream) within a grunt plugin?

Utilizing $rootScope in AngularJS as a central data repository

Generating a three-dimensional sphere from flat coordinates with the help of sine and cosine functions

Extract the content from a widget on a different site

Enhance user experience by implementing an autocomplete feature for a text input field

Inserting a new row into a particular table

JavaScript, CSS, and HTML - elements that dynamically adjust their size according to the content they hold

React eliminates all white spaces

jQuery Ajax error 403 (unlike XMLHttpRequest)

Express.js error: Unexpected closing parenthesis after argument list