The function and if-else statement are experiencing malfunctions

Question

The function and if-else statement are experiencing malfunctions

Currently in the early stages of learning coding, I've been focusing on building a solid foundation by practicing with CodeWars. Utilizing this platform for practice has been beneficial because it offers solutions for guidance. While attempting to work through a particular function written in Javascript, I realized that I'm facing challenges as the output is only an empty array []. Here's the problem statement, code snippet, and the actual output:

Challenging Problem Statement

The task is to create a method that takes an integer array as input and processes each number accordingly. The function should return a new array based on specific rules: If the number has a perfect square root, use that value; otherwise, square the number. For example, given [4,3,9,7,2,1], the expected output is [2,9,3,49,4,1]

The Troubling CODE

function squareOrSquareRoot(array) {

    var newValues = []; 
    
    for (i = 0; i < array.length; i++){ 
        
        var initial = array[i]; 
        var sqrt = Math.sqrt(initial); 

        if (Number.isInteger(sqrt)){ 
            newValues.push[sqrt];
        } 
        else { 
            newValues.push[initial*initial];  
        }
    }
    return newArray; 
}

Puzzling OUTPUT

Expected Output: '[2, 9, 3, 49, 4, 1]', Actual Output: '[]'

Expected Output: '[10, 10201, 25, 25, 1, 1]', Actual Output: '[]'

Expected Output: '[1, 4, 9, 2, 25, 36]', Actual Output: '[]'

javascript arrays function loops

Answer 1

Answer №1

Your current situation has a flaw. Please adjust the code below:

Number.isInteger(sqrt) == 'true'

to

Number.isInteger(sqrt) == true

The function Number.isInteger returns a boolean value, not a string. Additionally, the second 'else if' statement is unnecessary. If isInteger returns false, simply execute the 'else' part instead of rechecking. Lastly, make sure to return newValues instead of newArray. I hope this explanation clarifies things for you.

Answer 2

Your current situation has a flaw. Please adjust the code below:

Number.isInteger(sqrt) == 'true'

to

Number.isInteger(sqrt) == true

The function Number.isInteger returns a boolean value, not a string. Additionally, the second 'else if' statement is unnecessary. If isInteger returns false, simply execute the 'else' part instead of rechecking. Lastly, make sure to return newValues instead of newArray. I hope this explanation clarifies things for you.

Answer 3

Answer №2

There are certain errors in your current approach.

Your function should return newValues instead of newArray.
Avoid using quotation marks for true or false.
Using if/else if for true/false is unnecessary. Use if/else instead.

Below is a corrected solution:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        Number.isInteger(Math.sqrt(array[i]))?newValues.push(Math.sqrt(array[i])):newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Input : [3,4,5,9,7,16,36,11]

Output: [9,2,25,3,49,4,6,121]

If you find the ternary expression confusing, here is an example with if/else statement:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        var initial = array[i];
        var sqrt = Math.sqrt(initial);
        if(Number.isInteger(sqrt)) 
            newValues.push(sqrt);
        else
            newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Answer 4

There are certain errors in your current approach.

Your function should return newValues instead of newArray.
Avoid using quotation marks for true or false.
Using if/else if for true/false is unnecessary. Use if/else instead.

Below is a corrected solution:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        Number.isInteger(Math.sqrt(array[i]))?newValues.push(Math.sqrt(array[i])):newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Input : [3,4,5,9,7,16,36,11]

Output: [9,2,25,3,49,4,6,121]

If you find the ternary expression confusing, here is an example with if/else statement:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        var initial = array[i];
        var sqrt = Math.sqrt(initial);
        if(Number.isInteger(sqrt)) 
            newValues.push(sqrt);
        else
            newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Answer 5

Answer №3

A more efficient approach would be to avoid using a for loop and instead utilize the array.map method.

function calculateSquareOrSquareRoot(array) {
  return array.map(function(number) {
    var squareRoot = Math.sqrt(number);
    return Number.isInteger(squareRoot) ? squareRoot : number * number;
  })
}

The Array.map function iterates over each item in the array, applies the specified function, and returns a new array with the results.

Answer 6

A more efficient approach would be to avoid using a for loop and instead utilize the array.map method.

function calculateSquareOrSquareRoot(array) {
  return array.map(function(number) {
    var squareRoot = Math.sqrt(number);
    return Number.isInteger(squareRoot) ? squareRoot : number * number;
  })
}

The Array.map function iterates over each item in the array, applies the specified function, and returns a new array with the results.

The function and if-else statement are experiencing malfunctions

Challenging Problem Statement

The Troubling CODE

Puzzling OUTPUT

Answer №1

Answer №2

Answer №3

Similar questions

Passing an empty JSON object through Ajax requests

Access the value of localStorage when the body has finished loading or when the document is fully

Error encountered in the main thread: Fail to click on element at current position

Create a custom countdown using Jquery and Javascript that integrates with MySQL and PHP to display the datetime in the format Y-m-d

Steps for adding a class to an element in VueJS

JavaScript Issue Causing Jquery Carousel Dysfunction

Checking the alignment of a label or element in the center of a webpage using javascript

Using numpy's vectorize function with a 2-dimensional array

Why is it necessary to use process.nextTick() to delay method execution within a PassportJs strategy using Express?

What is the process for adding images from CSS (backgrounds, etc.) to the build folder with webpack?

Is innerHTML incapable of executing JavaScript code?

The function react.default.memo is not recognized at the createSvgIcon error

The RxJs Observer connected to a websocket only triggers for a single subscriber

I'm encountering a RangeError in nextjs when trying to pass props to a child component

Retrieve identical values from an array and display them using Vue.js

Exploring Angular Factory: Creating the getAll method for accessing RESTful APIs

Can an AJAX upload progress bar be implemented in Internet Explorer without using Flash?

Unable to showcase information in a jQuery UI popup through AJAX when initially presented

Using Vue: Triggering .focus() on a button click

What is the method to retrieve the value from $.get()?