The function and if-else statement are experiencing malfunctions

Question

The function and if-else statement are experiencing malfunctions

Currently in the early stages of learning coding, I've been focusing on building a solid foundation by practicing with CodeWars. Utilizing this platform for practice has been beneficial because it offers solutions for guidance. While attempting to work through a particular function written in Javascript, I realized that I'm facing challenges as the output is only an empty array []. Here's the problem statement, code snippet, and the actual output:

Challenging Problem Statement

The task is to create a method that takes an integer array as input and processes each number accordingly. The function should return a new array based on specific rules: If the number has a perfect square root, use that value; otherwise, square the number. For example, given [4,3,9,7,2,1], the expected output is [2,9,3,49,4,1]

The Troubling CODE

function squareOrSquareRoot(array) {

    var newValues = []; 
    
    for (i = 0; i < array.length; i++){ 
        
        var initial = array[i]; 
        var sqrt = Math.sqrt(initial); 

        if (Number.isInteger(sqrt)){ 
            newValues.push[sqrt];
        } 
        else { 
            newValues.push[initial*initial];  
        }
    }
    return newArray; 
}

Puzzling OUTPUT

Expected Output: '[2, 9, 3, 49, 4, 1]', Actual Output: '[]'

Expected Output: '[10, 10201, 25, 25, 1, 1]', Actual Output: '[]'

Expected Output: '[1, 4, 9, 2, 25, 36]', Actual Output: '[]'

javascript arrays function loops

Answer 1

Answer №1

Your current situation has a flaw. Please adjust the code below:

Number.isInteger(sqrt) == 'true'

to

Number.isInteger(sqrt) == true

The function Number.isInteger returns a boolean value, not a string. Additionally, the second 'else if' statement is unnecessary. If isInteger returns false, simply execute the 'else' part instead of rechecking. Lastly, make sure to return newValues instead of newArray. I hope this explanation clarifies things for you.

Answer 2

Your current situation has a flaw. Please adjust the code below:

Number.isInteger(sqrt) == 'true'

to

Number.isInteger(sqrt) == true

The function Number.isInteger returns a boolean value, not a string. Additionally, the second 'else if' statement is unnecessary. If isInteger returns false, simply execute the 'else' part instead of rechecking. Lastly, make sure to return newValues instead of newArray. I hope this explanation clarifies things for you.

Answer 3

Answer №2

There are certain errors in your current approach.

Your function should return newValues instead of newArray.
Avoid using quotation marks for true or false.
Using if/else if for true/false is unnecessary. Use if/else instead.

Below is a corrected solution:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        Number.isInteger(Math.sqrt(array[i]))?newValues.push(Math.sqrt(array[i])):newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Input : [3,4,5,9,7,16,36,11]

Output: [9,2,25,3,49,4,6,121]

If you find the ternary expression confusing, here is an example with if/else statement:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        var initial = array[i];
        var sqrt = Math.sqrt(initial);
        if(Number.isInteger(sqrt)) 
            newValues.push(sqrt);
        else
            newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Answer 4

There are certain errors in your current approach.

Your function should return newValues instead of newArray.
Avoid using quotation marks for true or false.
Using if/else if for true/false is unnecessary. Use if/else instead.

Below is a corrected solution:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        Number.isInteger(Math.sqrt(array[i]))?newValues.push(Math.sqrt(array[i])):newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Input : [3,4,5,9,7,16,36,11]

Output: [9,2,25,3,49,4,6,121]

If you find the ternary expression confusing, here is an example with if/else statement:

function squareOrSquareRoot(array) {

    var newValues = []; 
    for(var i = 0 ; i<array.length ;i++) {
        var initial = array[i];
        var sqrt = Math.sqrt(initial);
        if(Number.isInteger(sqrt)) 
            newValues.push(sqrt);
        else
            newValues.push(array[i]*array[i]);
    }
    return newValues;
}

var a = [3,4,5,9,7,16,36,11];
console.log('Input : ' + a);
console.log('Output: ' + squareOrSquareRoot(a));

Answer 5

Answer №3

A more efficient approach would be to avoid using a for loop and instead utilize the array.map method.

function calculateSquareOrSquareRoot(array) {
  return array.map(function(number) {
    var squareRoot = Math.sqrt(number);
    return Number.isInteger(squareRoot) ? squareRoot : number * number;
  })
}

The Array.map function iterates over each item in the array, applies the specified function, and returns a new array with the results.

Answer 6

A more efficient approach would be to avoid using a for loop and instead utilize the array.map method.

function calculateSquareOrSquareRoot(array) {
  return array.map(function(number) {
    var squareRoot = Math.sqrt(number);
    return Number.isInteger(squareRoot) ? squareRoot : number * number;
  })
}

The Array.map function iterates over each item in the array, applies the specified function, and returns a new array with the results.

The function and if-else statement are experiencing malfunctions

Challenging Problem Statement

The Troubling CODE

Puzzling OUTPUT

Answer №1

Answer №2

Answer №3

Similar questions

JavaScript's Set data structure does not allow for the storage of strings

Retrieving a JSON element using its name within a subquery in a Node.js MySQL environment

Exploring the potential of Framework7 in Single Page Applications: optimizing performance by preloading

Populate select2 with the selected value from select1 without the need to refresh the page or click a button

Determine the Mean of Every Set of Values Extracted from a Document

Providing dual outputs simultaneously within a function

Tips for verifying conditional input fields in a React component?

Swipe to modify Array

PugJS is failing to properly interpolate numbers from the JSON file

To clear the previous result of an AJAX call in JavaScript, reset the function or variable

Looking to add a close button to the iFrame, but having trouble getting it to function when clicked

Tips for Maintaining Table Headers in Place While Scrolling Through a Table

The JavaScript array on its second usage had a length of '0', yet it still contained objects within it

Unable to retrieve information from the firestore database

Leveraging the flexibility of an undefined variable as a useEffect dependency

Tips for retrieving JSON data from an AJAX call and displaying it pre-filled in an input field

What is the best way to remove an object from an array in MongoDB?

Issue with alert dismissal button not visible

TinyMCE: Tips for adding and highlighting text in your content!

Analyzing the DOM content loading time for web pages generated using AJAX technology