Streamlined JavaScript function with code that closely mirrors the original version

Question

Streamlined JavaScript function with code that closely mirrors the original version

Hey there, I'm currently developing an app that simulates pricing. Below is a snippet of the code I am working on:

  function calculatePrice(x) {
     if (x >= '1' && x <= '50') {
         var sum = (120 * x);
         hasil.value = 'Rp.' + parseFloat(sum * 1000);
     } else if (x >= '51' && x <= '100') {
         var sum = (115 * x);
         hasil.value = 'Rp.' + parseFloat(sum * 1000);
     } else if (x >= '101' && x <= '200') {
         var sum = (110 * x);
         hasil.value = 'Rp.' + parseFloat(sum * 1000);
     } else {
         hasil.value = 'error!';
     }
 }

I have multiple functions like this and I am looking for a way to simplify it into just one function. Is it possible?

javascript function

Answer 1

Answer №1

Give it a shot:

  function calculateTotalPrice(quantity, maxval) {
    if (quantity >= '1' && quantity <= '50') {
      var total = (maxval + 10) * quantity;
      result.value = 'Rp.' + parseFloat(total * 1000);
    }
     else if (quantity >= '51' && quantity <= '100') {
       var total = (maxval + 5) * quantity;
       result.value = 'Rp.' + parseFloat(total * 1000);
     }
     else if (quantity >= '101' && quantity <= '200') {
       var total = maxval * quantity;
       result.value = 'Rp.' + parseFloat(total * 1000);
     }
     else {
       result.value = 'error!';
     }
  }

Just to clarify, I am assuming that the increment value for maxval is 5. If more information is provided, a more accurate solution can be presented.

Answer 2

Give it a shot:

  function calculateTotalPrice(quantity, maxval) {
    if (quantity >= '1' && quantity <= '50') {
      var total = (maxval + 10) * quantity;
      result.value = 'Rp.' + parseFloat(total * 1000);
    }
     else if (quantity >= '51' && quantity <= '100') {
       var total = (maxval + 5) * quantity;
       result.value = 'Rp.' + parseFloat(total * 1000);
     }
     else if (quantity >= '101' && quantity <= '200') {
       var total = maxval * quantity;
       result.value = 'Rp.' + parseFloat(total * 1000);
     }
     else {
       result.value = 'error!';
     }
  }

Just to clarify, I am assuming that the increment value for maxval is 5. If more information is provided, a more accurate solution can be presented.

Answer 3

Answer №2

Here's how I would approach this task. While I may have a different perspective on handling integers, coding style is subjective. I prefer passing in an object containing the necessary values rather than duplicating logic. Although some might frown upon monkeypatching String, it serves the purpose in this scenario where variable x is assumed to be a string.

String.prototype.isWithinRange = function(lower, upper){
  const int = parseInt(this)
  return int >= parseInt(lower) && int <= parseInt(upper)
}

const range120 = {0: 120, 1: 115, 2: 110}
const range125 = {0: 125, 1: 120, 2: 115}
function calculateMax(x, values) {
  let total
  hasil.value = ''
  if (x.isWithinRange('1', '50')) {
    total = values['0'] * x
  } else if (x.isWithinRange('51', '100')) {
    total = values['1'] * x
  } else if (x.isWithinRange('101', '200')) {
    total = values['2'] * x
  } else {
    hasil.value = 'error'
  }
  hasil.value = hasil.value ? 'error' : 'Rp.'+parseFloat(total*1000);
}

Answer 4

Here's how I would approach this task. While I may have a different perspective on handling integers, coding style is subjective. I prefer passing in an object containing the necessary values rather than duplicating logic. Although some might frown upon monkeypatching String, it serves the purpose in this scenario where variable x is assumed to be a string.

String.prototype.isWithinRange = function(lower, upper){
  const int = parseInt(this)
  return int >= parseInt(lower) && int <= parseInt(upper)
}

const range120 = {0: 120, 1: 115, 2: 110}
const range125 = {0: 125, 1: 120, 2: 115}
function calculateMax(x, values) {
  let total
  hasil.value = ''
  if (x.isWithinRange('1', '50')) {
    total = values['0'] * x
  } else if (x.isWithinRange('51', '100')) {
    total = values['1'] * x
  } else if (x.isWithinRange('101', '200')) {
    total = values['2'] * x
  } else {
    hasil.value = 'error'
  }
  hasil.value = hasil.value ? 'error' : 'Rp.'+parseFloat(total*1000);
}

Answer 5

Answer №3

function calculateTotal(x, extra) {
  var totalAmount = extra;
  if(x >= '1' && x <= '50'){
   totalAmount += 120;
  }
  else if (x >= '51' && x <= '100'){
   totalAmount += 115;
  }
  else if(x >= '101' && x <= '200'){
   totalAmount += 110;
  }

  if(x < 1 && x > 200){
    output.value = 'error!';
  } else {
    output.value = 'Rp.'+parseFloat((totalAmount) * x *1000);
  }
}

The extra parameter can be set as 0 or 5 for the functions max110 or max115

Answer 6

function calculateTotal(x, extra) {
  var totalAmount = extra;
  if(x >= '1' && x <= '50'){
   totalAmount += 120;
  }
  else if (x >= '51' && x <= '100'){
   totalAmount += 115;
  }
  else if(x >= '101' && x <= '200'){
   totalAmount += 110;
  }

  if(x < 1 && x > 200){
    output.value = 'error!';
  } else {
    output.value = 'Rp.'+parseFloat((totalAmount) * x *1000);
  }
}

The extra parameter can be set as 0 or 5 for the functions max110 or max115

Answer 7

Answer №4

Essentially, you are dealing with two functions that operate in the same manner and produce similar outcomes with varying values.

The distinct values can be stored in an array, allowing for the use of a single function to retrieve the index and fetch the corresponding value from the array based on that index.
Therefore, it is crucial to organize the variables types effectively. If a variable is intended to be used as a number, then it should strictly be treated as a number. This also applies to comparisons, where both sides of the condition should involve numbers.
Opt for a pure function that does not modify any external state, which means all necessary data should be provided to the function explicitly.
Incorporate checks within the function to handle unwanted values and terminate early if needed. A preliminary check at the lower boundary, such as zero or below, can directly return -1 since it doesn't correspond to a valid array index (resembling the behavior of Array#indexOf).
Similarly, perform an early exit by checking against the upper boundary without requiring additional else if structures.
Lastly, ensure to return -1 when the index is not found upon completion.

Summarized:

function getValue(x, maxArray) {
    var index = getIndex(x);
    if (index in maxArray) {
        return 'Rp.' + maxArray[index] * x * 1000;
    }
    return 'error!';
}

function getIndex(x) {
    if (!x || x < 0) {
        return -1;
    }
    if (x <= 50) {
        return 0;
    }
    if (x <= 100) {
        return 1;
    }
    if (x <= 200) {
        return 2;
    }
    return -1;
}

var max110 = [120, 115, 110],
    max115 = [125, 120, 115];

console.log(getValue(-1, max110));
console.log(getValue(10, max110));
console.log(getValue(10, max115));

Answer 8

Essentially, you are dealing with two functions that operate in the same manner and produce similar outcomes with varying values.

The distinct values can be stored in an array, allowing for the use of a single function to retrieve the index and fetch the corresponding value from the array based on that index.
Therefore, it is crucial to organize the variables types effectively. If a variable is intended to be used as a number, then it should strictly be treated as a number. This also applies to comparisons, where both sides of the condition should involve numbers.
Opt for a pure function that does not modify any external state, which means all necessary data should be provided to the function explicitly.
Incorporate checks within the function to handle unwanted values and terminate early if needed. A preliminary check at the lower boundary, such as zero or below, can directly return -1 since it doesn't correspond to a valid array index (resembling the behavior of Array#indexOf).
Similarly, perform an early exit by checking against the upper boundary without requiring additional else if structures.
Lastly, ensure to return -1 when the index is not found upon completion.

Summarized:

function getValue(x, maxArray) {
    var index = getIndex(x);
    if (index in maxArray) {
        return 'Rp.' + maxArray[index] * x * 1000;
    }
    return 'error!';
}

function getIndex(x) {
    if (!x || x < 0) {
        return -1;
    }
    if (x <= 50) {
        return 0;
    }
    if (x <= 100) {
        return 1;
    }
    if (x <= 200) {
        return 2;
    }
    return -1;
}

var max110 = [120, 115, 110],
    max115 = [125, 120, 115];

console.log(getValue(-1, max110));
console.log(getValue(10, max110));
console.log(getValue(10, max115));

Streamlined JavaScript function with code that closely mirrors the original version

Answer №1

Answer №2

Answer №3

Answer №4

Similar questions

Is it possible to transfer a file or folder to a different location within the Google Drive API?

Modal containing Jquery GalleryView

Sending JavaScript variables to an ArrayList in a Java servlet

Retrieve the data stored in a concealed input field within a specific row of a table

I am looking to extract the content of the title within an HTML table

Tips for adding an active class when a link is clicked

Is utilizing the correct use case for a Bunyan child logger?

Transmitting data in JSON format via a RESTful API

Display a notification when the browser is being closed, but refrain from showing the notification when the closure is due to logging off

Is there a way to configure the bootstrap datetimepicker to only allow selection of time

The second request made with $.ajax is bypassed

Is there a way to include the ID of the currently logged-in user when making a call to axios.get in react-redux?

Form with dynamic input fields - starting values

The page transition on Android lacks fluidity

When there are numerous websocket connections in Google Chrome, Socket.io can encounter issues and break down

What is the best way to select and link a specific section of a string using Javascript?

Leveraging the power of dual layouts in Nuxt 3

Having trouble configuring the sticky-footer correctly

Selenium javascript is displaying error codes when trying to retrieve console logs

Is there a way to make Firebase Cloud Functions utilize ESLint?