JS: Use either $addToSet or $pull based on the current availability of the value

Question

JS: Use either $addToSet or $pull based on the current availability of the value

I am looking for a more efficient way to add or remove an ID from an array (target) in an Articles object, based on whether it already exists. Currently, I am using the following approach:

var isExisting = Articles.findOne({ _id }).target.indexOf(mID) > -1

if (isExisting === false) {
  Articles.update(
      { _id },
      { $addToSet: { target: mID } }
    )
} else if (isExisting === true) {
  Articles.update(
    { _id },
    { $pull: { target: mID } }
  )
}

Could there be a more optimal way to achieve this without the need for if/else statements and a minimum of two database operations?

javascript mongodb meteor

Answer 1

Answer №1

Executing Mongoose operations asynchronously means waiting for the callback to retrieve the document.

// Find the article by its ID
Articles.findById(_id, function (err, article) {
    // Make appropriate changes based on whether mID exists in the article's target
    if (article.target.indexOf(mID) > -1)
        article.target.pull(mID)
    else
        article.target.push(mID)
    // Save the changes
    article.save(function (err) {

    });
})

Although you're using an if/else statement, you're essentially performing two operations.

Answer 2

Executing Mongoose operations asynchronously means waiting for the callback to retrieve the document.

// Find the article by its ID
Articles.findById(_id, function (err, article) {
    // Make appropriate changes based on whether mID exists in the article's target
    if (article.target.indexOf(mID) > -1)
        article.target.pull(mID)
    else
        article.target.push(mID)
    // Save the changes
    article.save(function (err) {

    });
})

Although you're using an if/else statement, you're essentially performing two operations.

Answer 3

Answer №2

below is a suggestion to improve the code

const checkExistingRecord = Articles.findOne({ _id: _id, target : mID}) //check if mID exists in array of [mIDs]
const query = { _id : _id };
const updateQuery = checkExistingRecord ? { $pull: { target: mID } } : { $addToSet: { target: mID } };

Articles.update(query, updateQuery);

Do you find this version clearer and more efficient?

Answer 4

below is a suggestion to improve the code

const checkExistingRecord = Articles.findOne({ _id: _id, target : mID}) //check if mID exists in array of [mIDs]
const query = { _id : _id };
const updateQuery = checkExistingRecord ? { $pull: { target: mID } } : { $addToSet: { target: mID } };

Articles.update(query, updateQuery);

Do you find this version clearer and more efficient?

JS: Use either $addToSet or $pull based on the current availability of the value

Answer №1

Answer №2

Similar questions

Experience the frustration when the Ruby on Rails Open Modal Box Link fails to work. Stay tuned for the latest update on the link

Exploring the Express problem with AWS SNS web service subscriptions using a Sinatra case study

Guide on dynamically applying a CSS rule to an HTML element using programming techniques

Updating language settings on-the-fly in a Vue application does not automatically refresh the translated content displayed on the website

Curious about the method of refining a list based on another list?

How can I show the real width of an image on a mobile device?

The functionality of the button in my script is limited to a single use

finding the index of a particular checkbox in a list

Creating a bot that will only respond once when a user sends multiple photos simultaneously

When the user clicks, the template data should be displayed on the current page

Encountering the error "Unable to access the 'pickAlgorithm' property of null" in a ReactJS context

The form is not being submitted when I click on the submit button because I have two buttons that trigger AJAX requests

Execute a function prior to making a synchronous call

What is the best way to keep a text editable in a razor editor without it vanishing?

Storing tweets in a mongodb database using nodejs

Which one should I prioritize learning first - AngularJS or Laravel?

What occurs to the bound event once the DOM element disappears?

"Error encountered in @mui/x-data-grid's ValueGetter function due to undefined parameters being passed

Animation is not applied to Bootstrap Collapse on a row within a table

Translate a jQuery ajax request utilizing jQuery().serialize into plain JavaScript