JavaScript substring() function in clone is experiencing an error

Question

JavaScript substring() function in clone is experiencing an error

I am currently working on a JavaScript function that determines whether a specific substring is present in a larger main string. For instance, if the main string is "111010" and the substring is "011," the expected result should be false since the substring does not exist within the main string. However, my code is returning true instead. Below is the snippet of the code:

var string = "111010",
substr = "011";     

var found=false;

outter:for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        inner:for(j=1;j<substr.length;j++){
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
                continue inner;
            }else{
              continue outter;
            }
        }
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

javascript string substring

Answer 1

Answer №1

Ensure you always re-initialize the found variable before each iteration.

var string = "111010",
substr = "0110";     

var found=false;

for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        for(j=1; j < substr.length;j ++)
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
            }else{
               found = false; // <<--this
               break;
            }
        if(found) break;   
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

Your code will return true if a common letter between your string and substring is found, fix this issue.

Avoid using labels in your code as they are not recommended. Thank you!

See the correct implementation of your code here.

var found = false;

for (var i = 0; i < string.length; i++) { // starting position
    found = true; // All letters match, prove otherwise

    for (j = 0; j < substr.length; j++) { // Compare the given string with the string starting at i
        if (string.charAt(i + j) != substr.charAt(j)) { // If one letter does not match, stop searching
            found = false;
            break;
        }       
    }

    if (found) break;
}

Avoid treating the first letter separately
Avoid using labels
Focus on finding non-matching letters instead of direct matches
Avoid unnecessary index variables like k, use j for needle position and i+j for hay position

Answer 2

Ensure you always re-initialize the found variable before each iteration.

var string = "111010",
substr = "0110";     

var found=false;

for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        for(j=1; j < substr.length;j ++)
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
            }else{
               found = false; // <<--this
               break;
            }
        if(found) break;   
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

Your code will return true if a common letter between your string and substring is found, fix this issue.

Avoid using labels in your code as they are not recommended. Thank you!

See the correct implementation of your code here.

var found = false;

for (var i = 0; i < string.length; i++) { // starting position
    found = true; // All letters match, prove otherwise

    for (j = 0; j < substr.length; j++) { // Compare the given string with the string starting at i
        if (string.charAt(i + j) != substr.charAt(j)) { // If one letter does not match, stop searching
            found = false;
            break;
        }       
    }

    if (found) break;
}

Avoid treating the first letter separately
Avoid using labels
Focus on finding non-matching letters instead of direct matches
Avoid unnecessary index variables like k, use j for needle position and i+j for hay position

Answer 3

Answer №2

Here is a snippet of code that demonstrates how to check for a specific substring within a string:

var mainString = "this is an example string", subString = "example";
var result = mainString.indexOf(subString);

if (result >= 0) { 
    alert('The substring exists in the main string.');
} else {
    alert('The substring does not exist in the main string.');
}

Answer 4

Here is a snippet of code that demonstrates how to check for a specific substring within a string:

var mainString = "this is an example string", subString = "example";
var result = mainString.indexOf(subString);

if (result >= 0) { 
    alert('The substring exists in the main string.');
} else {
    alert('The substring does not exist in the main string.');
}

JavaScript substring() function in clone is experiencing an error

Answer №1

Answer №2

Similar questions

Is it possible to use jquery to specifically target classes?

Sending numerous data fields via ajax

Using the IE method getelementbyid to target an object within the document

Is there a way to block the .load() function directly from the browser console?

Explore RxJs DistinctUntilChanged for Deep Object Comparison

Retrieving external JSON data with JavaScript

Issue with MongoDB find() function not retrieving any results (Assignment)

Discover the power of AngularJS's ng-route feature for creating a dynamic and seamless one-page HTML template experience

Updating or swapping images using JavaScript and HTML

Enzyme locates and chooses the initial occurrence of an element

Encountering difficulty importing TypeScript files dynamically within a Deno executable

"Trouble arises when event listener fails to function following an append operation

jQuery is not updating the div as expected

Reserve a spot for a credit card in 4-digit format with VueJS

Is it possible to move the res.send() outside of the function in node.js?

Angular.js and ExpressJS combination results in a 404 error for a POST request

The interface vanishes upon the integration of TinyMCE into the module

Notify immediately if there is any clicking activity detected within a designated div container

Access remote web page within bootstrap modal

Updating a property in an object within an Angular service and accessing it in a different controller