JavaScript substring() function in clone is experiencing an error

Question

JavaScript substring() function in clone is experiencing an error

I am currently working on a JavaScript function that determines whether a specific substring is present in a larger main string. For instance, if the main string is "111010" and the substring is "011," the expected result should be false since the substring does not exist within the main string. However, my code is returning true instead. Below is the snippet of the code:

var string = "111010",
substr = "011";     

var found=false;

outter:for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        inner:for(j=1;j<substr.length;j++){
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
                continue inner;
            }else{
              continue outter;
            }
        }
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

javascript string substring

Answer 1

Answer №1

Ensure you always re-initialize the found variable before each iteration.

var string = "111010",
substr = "0110";     

var found=false;

for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        for(j=1; j < substr.length;j ++)
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
            }else{
               found = false; // <<--this
               break;
            }
        if(found) break;   
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

Your code will return true if a common letter between your string and substring is found, fix this issue.

Avoid using labels in your code as they are not recommended. Thank you!

See the correct implementation of your code here.

var found = false;

for (var i = 0; i < string.length; i++) { // starting position
    found = true; // All letters match, prove otherwise

    for (j = 0; j < substr.length; j++) { // Compare the given string with the string starting at i
        if (string.charAt(i + j) != substr.charAt(j)) { // If one letter does not match, stop searching
            found = false;
            break;
        }       
    }

    if (found) break;
}

Avoid treating the first letter separately
Avoid using labels
Focus on finding non-matching letters instead of direct matches
Avoid unnecessary index variables like k, use j for needle position and i+j for hay position

Answer 2

Ensure you always re-initialize the found variable before each iteration.

var string = "111010",
substr = "0110";     

var found=false;

for(var i=0;i<string.length;i++){
    if(string.charAt(i)==substr.charAt(0)){                   
        var k=i+1;
        for(j=1; j < substr.length;j ++)
            if(string.charAt(k++)==substr.charAt(j)){
                found=true;
            }else{
               found = false; // <<--this
               break;
            }
        if(found) break;   
    }
}

if(found!=false){
    console.log("y")
}else{
    console.log("n");
}

Your code will return true if a common letter between your string and substring is found, fix this issue.

Avoid using labels in your code as they are not recommended. Thank you!

See the correct implementation of your code here.

var found = false;

for (var i = 0; i < string.length; i++) { // starting position
    found = true; // All letters match, prove otherwise

    for (j = 0; j < substr.length; j++) { // Compare the given string with the string starting at i
        if (string.charAt(i + j) != substr.charAt(j)) { // If one letter does not match, stop searching
            found = false;
            break;
        }       
    }

    if (found) break;
}

Avoid treating the first letter separately
Avoid using labels
Focus on finding non-matching letters instead of direct matches
Avoid unnecessary index variables like k, use j for needle position and i+j for hay position

Answer 3

Answer №2

Here is a snippet of code that demonstrates how to check for a specific substring within a string:

var mainString = "this is an example string", subString = "example";
var result = mainString.indexOf(subString);

if (result >= 0) { 
    alert('The substring exists in the main string.');
} else {
    alert('The substring does not exist in the main string.');
}

Answer 4

Here is a snippet of code that demonstrates how to check for a specific substring within a string:

var mainString = "this is an example string", subString = "example";
var result = mainString.indexOf(subString);

if (result >= 0) { 
    alert('The substring exists in the main string.');
} else {
    alert('The substring does not exist in the main string.');
}

JavaScript substring() function in clone is experiencing an error

Answer №1

Answer №2

Similar questions

Steps for updating the property "project_id" within a nested JSON array to "project_name"

What is the best way to determine if an item in an array is not empty?

Avoid refreshing the page upon pressing the back button in AngularJS

Ways to effectively manage multiple asynchronous operations while retrieving emails and attachments using IMAP and JavaScript

Add empty objects to an array using a push function following the Vue JS constructor function

The error message "Data type must be consistent across all series on a single axis in Google Chart" may cause confusion

Connect to the Kendo dropdown list undefined

Correctly referencing a variable in a delayed AJAX request is crucial for ensuring the proper execution

Google Maps API now offers the ability to generate directions with up to 500 waypoints

The GIF Loader fails to animate while an AJAX request is in progress

Highly complex regular expressions in nth-check causing inefficiencies during npm installation of react-router-dom

Substitute the ajax reply with the text currently displayed

The URL not functioning properly after including the .active class with JQuery

Is it possible to concurrently hot module reload both the server (.NET Core) and client (Angular)?

AngularJS: Display the last four characters of a string and substitute the rest with 'X'

Getting an input value dynamically in a React variable when there is a change in the input field

Analyzing objects within an array for similarities

Error in React Toaster preventing redirect with useHistory() before reaching another page

Developing pagination functionality in ReactJS

Inspecting Facebook links