JavaScript implementation of the results sorting

Question

JavaScript implementation of the results sorting

I have 2 sql queries to calculate the turnover for each semester.

Results from query 1:

{
  "LRU": [
    "RADOME",
    "RADOME",
    "ATSU",
    "MFC",
    "FWC",
    "Unspecified",
    "AZE",
    "ECP",
    "CMM",
    "ECP"
  ],
  "Client": [
    17346,
    17512,
    7262,
    17242,
    4001,
    17164,
    7277,
    17334,
    8059,
    300015
  ],
  "round": [
    -33250,
    -13358,
    -11731,
    -10506,
    -6005,
    -3132,
    -2448,
    -2369,
    -2236,
    -2074
  ]
}

Results from query 2:

{
  "LRU": [
    "RADOME",
    "RADOME",
    "ECP",
    "PRIM",
    "MFC",
    "FWC",
    "RCI",
    "TAV",
    "CAL",
    "ECP"
  ],
  "Client": [
    17223,
    17346,
    7262,
    7956,
    594,
    4001,
    7277,
    17260,
    347,
    8059
  ],
  "round": [
    -34276,
    -33250,
    -11731,
    -6273,
    -5684,
    -4200,
    -2723,
    -2586,
    -2510,
    -2236
  ]
}

I created a javascript function to calculate the average variation between the 2 queries, sort them, and identify the top 10 customers with increased turnover and the bottom 10 customers with decreased turnover.
Here is my function:

    var query1 = {{repair_semester1}};
var query2 = {{repair_semester2}};
var data = {};
[query1, query2].forEach(function (query, semester) {
    query.Client.forEach(function(clientId, index) {
        var client = data[clientId] = data[clientId] || {};
        var clientArt = client[query.LRU[index]] = client[query.LRU[index]] || [0, 0];
        clientArt[semester] = query.round[index];
    });
});

// Now report on that data
var output = [];

for (client in data) {
    for (article in data[client]) {
        var turnovers = data[client][article];
            output.push(formatName(client,article,turnovers));
        }
}

function formatName(client, article, turnover, a) {

    return("Client: " + client + ", LRU.: " + article 
                  + ", semester t/o: " + turnovers
                  + " " + (turnovers[0] === 0 ?
                                       turnovers[1] : 
                              ((turnovers[1]-turnovers[0]) /turnovers[0])*100

        ));

}

percent.sort(function (a, b) {
    return b.percent - a.percent;
});

return("top", percent.slice(0, 10));
return("bottom", percent.slice(-10));    
return(output);

Here are some sample results:

  {
  "output": [
    "Client: 347, LRU.: ECP, semester t/o: 0,-2510 -2510",
    "Client: 394, LRU.: ATSU, semester t/o: 0,10433 10433",
    "Client: 394, LRU.: FCPC, semester t/o: 0,3023 3023",
    "Client: 417, LRU.: FWC, semester t/o: 0,17683 17683",
    ...
   ]
}

Please help me correct the function to determine the customers with the highest and lowest turnover variations along with their corresponding LRUs. Thank you.

javascript

Answer 1

Answer №1

This strategy is centered around the provided objects and aims to achieve the desired outcome by utilizing an object that possesses the necessary properties, arranging it based on percentage.

In order to extract the top 10 percent values, the array is sliced and a new array is generated, which is then analyzed to obtain the desired information in string format. This process is similarly applied for the bottom 10 percent values.

function formatName(o) {
    return "Client: " + o.client + ", LRU.: " + o.article + ", semester t/o: " + o.turnovers + " " + o.percent;
}

var query1 = {
        LRU: ["RADOME", "RADOME", "Unspecified", "Unspecified", "Unspecified", "Unspecified", "Unspecified", "ECP", "ECP", "ECP"],
        Client: [17346, 17512, 7262, 17242, 4001, 17164, 7277, 17334, 8059, 300015],
        round: [-33250, -13358, -11731, -10506, -6005, -3132, -2448, -2369, -2236, -2074]
    },
    query2 = {
        LRU: ["RADOME", "RADOME", "Unspecified", "PRIM", "Unspecified", "Unspecified", "Unspecified", "ECP", "ECP", "ECP"],
        Client: [17223, 17346, 7262, 7956, 594, 4001, 7277, 17260, 347, 8059],
        round: [-34276, -33250, -11731, -6273, -5684, -4200, -2723, -2586, -2510, -2236]
    },
    data = {},
    output = [],
    max,
    min,
    client,
    article,
    turnovers;

[query1, query2].forEach(function (query, semester) {
    query.Client.forEach(function (clientId, index) {
        var client = data[clientId] = data[clientId] || {};
        var clientArt = client[query.LRU[index]] = client[query.LRU[index]] || [0, 0];
        clientArt[semester] = query.round[index];
    });
});

for (client in data) {
    for (article in data[client]) {
        turnovers = data[client][article];
        output.push({ client, article, turnovers, percent: turnovers[0] === 0 ? turnovers[1] : (turnovers[1] - turnovers[0]) * 100 / turnovers[0] });
    }
}

output.sort(function (a, b) {
    return b.percent - a.percent;
});

max = output.slice(0, 10); // get top 10
min = output.slice(-10);   // get bottom 10

console.log(max.map(formatName));
console.log(min.map(formatName));
console.log(output);

.as-console-wrapper { max-height: 100% !important; top: 0; }

Answer 2

This strategy is centered around the provided objects and aims to achieve the desired outcome by utilizing an object that possesses the necessary properties, arranging it based on percentage.

In order to extract the top 10 percent values, the array is sliced and a new array is generated, which is then analyzed to obtain the desired information in string format. This process is similarly applied for the bottom 10 percent values.

function formatName(o) {
    return "Client: " + o.client + ", LRU.: " + o.article + ", semester t/o: " + o.turnovers + " " + o.percent;
}

var query1 = {
        LRU: ["RADOME", "RADOME", "Unspecified", "Unspecified", "Unspecified", "Unspecified", "Unspecified", "ECP", "ECP", "ECP"],
        Client: [17346, 17512, 7262, 17242, 4001, 17164, 7277, 17334, 8059, 300015],
        round: [-33250, -13358, -11731, -10506, -6005, -3132, -2448, -2369, -2236, -2074]
    },
    query2 = {
        LRU: ["RADOME", "RADOME", "Unspecified", "PRIM", "Unspecified", "Unspecified", "Unspecified", "ECP", "ECP", "ECP"],
        Client: [17223, 17346, 7262, 7956, 594, 4001, 7277, 17260, 347, 8059],
        round: [-34276, -33250, -11731, -6273, -5684, -4200, -2723, -2586, -2510, -2236]
    },
    data = {},
    output = [],
    max,
    min,
    client,
    article,
    turnovers;

[query1, query2].forEach(function (query, semester) {
    query.Client.forEach(function (clientId, index) {
        var client = data[clientId] = data[clientId] || {};
        var clientArt = client[query.LRU[index]] = client[query.LRU[index]] || [0, 0];
        clientArt[semester] = query.round[index];
    });
});

for (client in data) {
    for (article in data[client]) {
        turnovers = data[client][article];
        output.push({ client, article, turnovers, percent: turnovers[0] === 0 ? turnovers[1] : (turnovers[1] - turnovers[0]) * 100 / turnovers[0] });
    }
}

output.sort(function (a, b) {
    return b.percent - a.percent;
});

max = output.slice(0, 10); // get top 10
min = output.slice(-10);   // get bottom 10

console.log(max.map(formatName));
console.log(min.map(formatName));
console.log(output);

.as-console-wrapper { max-height: 100% !important; top: 0; }

Answer 3

Answer №2

The function called formatName requires 4 parameters to work correctly:

function formatName(client, article, turnover, a)

However, you are only providing 3 parameters when calling it:

output.push(formatName(client, article, turnovers));

Attempting to use the fourth parameter will not be successful. You need to either make the parameter optional and check if it is set or ensure that you pass all required parameters each time you call the function.

EDIT: Upon further review, errors have been identified from before.

The variable 'data' is defined as an object instead of an array, making it impossible to push variables into it or iterate over it.
In your initial loops, you are creating variables but failing to push them into the data array. Make use of data.push(key, value).

When executing this line:

var client = data[clientId] = data[clientId] || {};

, you are simply assigning the value of an empty variable 'client' with the value of 'data[clientId]' which is also empty.

Furthermore, there is no sorting function present to sort the output. Your sort function only performs subtraction.
Lastly, your syntax appears confusing with returns outside of functions.

These are the main issues within the code. Correcting these mistakes should yield better results.

Answer 4

The function called formatName requires 4 parameters to work correctly:

function formatName(client, article, turnover, a)

However, you are only providing 3 parameters when calling it:

output.push(formatName(client, article, turnovers));

Attempting to use the fourth parameter will not be successful. You need to either make the parameter optional and check if it is set or ensure that you pass all required parameters each time you call the function.

EDIT: Upon further review, errors have been identified from before.

The variable 'data' is defined as an object instead of an array, making it impossible to push variables into it or iterate over it.
In your initial loops, you are creating variables but failing to push them into the data array. Make use of data.push(key, value).

When executing this line:

var client = data[clientId] = data[clientId] || {};

, you are simply assigning the value of an empty variable 'client' with the value of 'data[clientId]' which is also empty.

Furthermore, there is no sorting function present to sort the output. Your sort function only performs subtraction.
Lastly, your syntax appears confusing with returns outside of functions.

These are the main issues within the code. Correcting these mistakes should yield better results.

JavaScript implementation of the results sorting

Answer №1

Answer №2

Similar questions

Retrieve information from a form in AngularJS without relying on two-way data binding

Storing knockout view model data in a database and fetching it back

Displaying an image in AngularJS using a byte array received in the response

Activate lighting in Three.js with a simple click

The phenomenon of an invisible Absolute or relative position leading to grid components overlapping in Next.js

My objective is to show the div element just once using AngularJS

What is the method for obtaining the properties of a type as an array in Typescript?

Is there a way to enable Tail Recursion Optimization in TypeScript?

Give a jQuery Mobile flipswitch a new look

Steady Content of a Parallax Webpage

Issues encountered when selecting table data for filtering

Tips for customizing your MUI slider design

Deactivating one div's class upon clicking on another div

What is the best way to show an on/off button in an HTML page when it loads, based on a value stored in a MySQL database?

Failed commitments in Protractor/WebDriverJS

Small-scale vue iterates through elements with v-for but fails to display them

Utilizing util.format to enclose every string within an array with double quotation marks

Issues arising from the event target

The Ajax page does not respond to click events when the function is declared within $(function(){ }) block

Is there a way to use fetch() to automatically redirect a user after logging in?