JavaScript Function is having issues when dealing with whole numbers

Question

JavaScript Function is having issues when dealing with whole numbers

When it comes to my JavaScript function designed to inquire about the number of products a user wants to order, I'm facing some issues. The function should display a message if the user tries to order less than one product and show an alert saying "Ordering (quantity) (product)[s]". Unfortunately, these features aren't working as intended.

I attempted to fix this by implementing a return for the quantity, but all it did was alter the webpage to display the quantity number. However, it did prove that the quantity functionality is functional.

function promptQuantity(product) {
  var quantity = prompt("How many " + product + "s would you like?");
  if (quantity > 1) {
    var plural = "s";
  }
  if (quantity = 1) {
    var plural = "";
  }
  if (quantity < 1) {
    alert("Don't be ridiculous! You can't order less than one " + product + "!");
  }
  if (quantity > 0) {
    alert("Ordering " + quantity + " " + product, plural);
  }
}

My expectation from this function is to send an alert notifying the user about their order quantity of the product, but unfortunately, it only returns as "Ordering 1 (product)".

javascript

Answer 1

Answer №1

To start, it is important to use '==' instead of '=' when comparing variables 'a' and 'b' for equality.

Additionally, if you already know that 'a' is greater than 'b', there is no need to check for '==' or '<'. It would be more efficient to utilize an if-else statement (or even a switch). Here is an optimized version:

function askAmount(item) {
  var amount = prompt("How many " + item + "s do you want?");
  var message = '';
  if (amount > 1) {
    message = "Ordering " + amount + " " + item + "s";
  } else if (amount == 1) {
    message = "Ordering " + amount + " " + item;
  } else {
    message = "That doesn't make sense! You cannot order less than one " + item + "!"
  }
  alert(message);
}

askAmount('banana');

Alternatively, you can use a switch statement, although the action may be less clear:

function askAmount(item) {
  var amount = prompt("How many " + item + "s do you want?");
  var message = '';
  switch (true) {
    case amount > 1:
      message = "Ordering " + amount + " " + item + "s";
      break;
    case amount == 1:
      message = "Ordering " + amount + " " + item;
      break;
    default:
      message = "That doesn't make sense! You cannot order less than one " + item + "!";
      break;
  }
  alert(message);
}

askAmount('banana');

Answer 2

To start, it is important to use '==' instead of '=' when comparing variables 'a' and 'b' for equality.

Additionally, if you already know that 'a' is greater than 'b', there is no need to check for '==' or '<'. It would be more efficient to utilize an if-else statement (or even a switch). Here is an optimized version:

function askAmount(item) {
  var amount = prompt("How many " + item + "s do you want?");
  var message = '';
  if (amount > 1) {
    message = "Ordering " + amount + " " + item + "s";
  } else if (amount == 1) {
    message = "Ordering " + amount + " " + item;
  } else {
    message = "That doesn't make sense! You cannot order less than one " + item + "!"
  }
  alert(message);
}

askAmount('banana');

Alternatively, you can use a switch statement, although the action may be less clear:

function askAmount(item) {
  var amount = prompt("How many " + item + "s do you want?");
  var message = '';
  switch (true) {
    case amount > 1:
      message = "Ordering " + amount + " " + item + "s";
      break;
    case amount == 1:
      message = "Ordering " + amount + " " + item;
      break;
    default:
      message = "That doesn't make sense! You cannot order less than one " + item + "!";
      break;
  }
  alert(message);
}

askAmount('banana');

Answer 3

Answer №2

The code snippet if (quantity = 1) contains an error, as it performs assignment rather than comparison. This means that the variable quantity will always be set to 1. To fix this, use if (quantity == 1) for proper comparison. Additionally, consider restructuring your code in the following way:

function inquireQuantity(item)
{
    var quantity = prompt("How many " + item + "s do you want?");
    var plural = quantity > 1 ? "s" : "";

    if (quantity < 1)
        alert("You can't order less than one " + item + "!");
    else
        alert("Ordering " + quantity + " " + item + plural);
}

inquireQuantity("T-shirt");

Answer 4

The code snippet if (quantity = 1) contains an error, as it performs assignment rather than comparison. This means that the variable quantity will always be set to 1. To fix this, use if (quantity == 1) for proper comparison. Additionally, consider restructuring your code in the following way:

function inquireQuantity(item)
{
    var quantity = prompt("How many " + item + "s do you want?");
    var plural = quantity > 1 ? "s" : "";

    if (quantity < 1)
        alert("You can't order less than one " + item + "!");
    else
        alert("Ordering " + quantity + " " + item + plural);
}

inquireQuantity("T-shirt");

JavaScript Function is having issues when dealing with whole numbers

Answer №1

Answer №2

Similar questions

Using Jquery and Ajax to add information to a database

Access a file from a specified route within Express

Counting down with Jquery when times run out

The HTML remains unchanged after making an AJAX request

Step-by-step guide for sending data using module.exports in a node.js application

The class may not consistently be assigned to the user when they are positioned at the top of the

Executing a function in AngularJS using PHP

The process of passing the ID value to another function is malfunctioning in JavaScript

The error message "The property 'find' cannot be found on the data type 'string[]'" indicates that the 'find' method is

Changing the hover background color and text color of Material UI Button

What is the process for implementing a title search filter in Vue.js?

InfoWindow from JSON data not displaying in Google Maps V3

Tips on selectively importing necessary functions/classes from Handlebars

Tips for implementing FontAwesome in Nuxt3

Having trouble with the burger menu not opening while using javascript

Troubleshooting: ngAnimate max-height failing to apply to specific element

Can you explain the purpose of App.hiddenDivs in jQuery code snippet provided?

Using jQuery's setInterval to consistently refresh the value of a data attribute

Using ServiceStack to deserialize an array

Wait until a svelte store value is set to true before fetching data (TypeScript)