Improve numerous conditions

Question

Improve numerous conditions

I am currently working on a project that involves Angular and Node. In this project, I have written a function with multiple if and else if statements containing various conditions. The code looks complex and lengthy, and I want to refactor it to make it more concise and clean. Although I tried using a switch statement, I haven't found a satisfactory solution yet.

if (
      (
        !orderRequest.paymentProvider
        || orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.ADYEN
      )
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.CREDITCARD
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
      const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);

      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.AdyenCreditCardPaymentMethodService
      };

      const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);

      return [
        mainPayment,
        ...giftCardsPayments
      ];
    } else if (
      orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.ADYEN
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.PAYPAL
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.ADYEN_PAYPAL, true);
      const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);

      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.adyenPayPalPaymentMethodService
      };

      const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);

      return [
        mainPayment,
        ...giftCardsPayments
      ];
    } else if (
      (
        !orderRequest.paymentProvider
        || orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.ADYEN
      )
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.INVOICE
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.INVOICE, true);
      const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);

      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.AdyenInvoicePaymentMethodService
      };

      const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);

      return [
        mainPayment,
        ...giftCardsPayments
      ];
    } else if (
      orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.GMO
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.CREDITCARD
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.GMOCreditCardPaymentMethodService
      };
      return [mainPayment];
    } else if (
      orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.COD
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.COD
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CASH_ON_DELIVERY, true);
      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.CashOnDeliveryPaymentService
      };
      return [mainPayment];
    } else if (
      (
        !orderRequest.paymentProvider
        || orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.ADYEN
      )
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.GIFTCERTIFICATE
    ) {
      const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
      return this.getGiftCardsPayments(giftCardPaymentInstruments);
    } else if (
      (
        !orderRequest.paymentProvider
        || orderRequest.paymentProvider === OrderRequestV2.PaymentProviderEnum.ADYEN
      )
      && orderRequest.paymentMethod === OrderRequestV2.PaymentMethodEnum.APPLEPAY
    ) {
      const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
      const mainPayment = {
        paymentInstrument: mainPaymentInstruments[0],
        paymentMethod: this.AdyenApplePayPaymentService
      };
      return [mainPayment];
    } 
    throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
  }

javascript

Answer 1

Answer №1

Consider enabling different payment providers and their respective payment methods individually. Since each provider has its own unique requirements, avoid creating a generic function to handle all cases.

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

const getPaymentMethods = async (orderRequest) => {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenCreditCardPaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case PAYPAL:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.ADYEN_PAYPAL, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.adyenPayPalPaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case INVOICE:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.INVOICE, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenInvoicePaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case GIFTCERTIFICATE:
            {
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
              return this.getGiftCardsPayments(giftCardPaymentInstruments);
            }
          case APPLEPAY:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenApplePayPaymentService
              };
              return [mainPayment];
            }
        }
        break;
      }
    case COD_PROVIDER:
      {
        switch (orderRequest.paymentMethod) {
          case COD_METHOD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CASH_ON_DELIVERY, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.CashOnDeliveryPaymentService
              };
              return [mainPayment];
            }
        }
        break;
      }
    case GMO:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.GMOCreditCardPaymentMethodService
              };
              return [mainPayment];
            }
        }
        break;
      }
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

To simplify the logic, you may create separate functions:

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

async function getPaymentMethods(orderRequest) {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            return this.paymentWithGiftCards(this.AdyenCreditCardPaymentMethodService);
          case PAYPAL:
            return this.paymentWithGiftCards(this.adyenPayPalPaymentMethodService);
          case INVOICE:
            return this.paymentWithGiftCards(this.AdyenInvoicePaymentMethodService);
          case GIFTCERTIFICATE:
            return giftPaymentOnly();
          case APPLEPAY:
            return this.simplePayment(this.AdyenApplePayPaymentService);
        }
        break;
      }
    case COD_PROVIDER:
      {
        switch (orderRequest.paymentMethod) {
          case COD_METHOD:
            return this.simplePayment(this.CashOnDeliveryPaymentService);
        }
        break;
      }
    case GMO:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            return this.simplePayment(this.GMOCreditCardPaymentMethodService);
        }
        break;
      }
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

async function paymentWithGiftCards(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod
  };
  const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
  return [mainPayment, ...giftCardsPayments];
}

async function simplePayment(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod: paymentMethod;
  };
  return [mainPayment];
}

async function giftPaymentOnly(paymentMethod) {
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
  return this.getGiftCardsPayments(giftCardPaymentInstruments);
}

To avoid nested switch statements, delegate each payment provider's call to specific functions:

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

async function getPaymentMethods(orderRequest) {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      return getAdyenPaymentMethods(orderRequest);
    case COD_PROVIDER:
      return getCodPaymentMethods(orderRequest);
    case GMO:
      return getGmoPaymentMethods(orderRequest);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

async function getAdyenPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case CREDITCARD:
      return this.paymentWithGiftCards(this.AdyenCreditCardPaymentMethodService);
    case PAYPAL:
      return this.paymentWithGiftCards(this.adyenPayPalPaymentMethodService);
    case INVOICE:
      return this.paymentWithGiftCards(this.AdyenInvoicePaymentMethodService);
    case GIFTCERTIFICATE:
      return giftPaymentOnly();
    case APPLEPAY:
      return this.simplePayment(this.AdyenApplePayPaymentService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function getCodPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case COD_METHOD:
      return this.simplePayment(this.CashOnDeliveryPaymentService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function getGmoPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case CREDITCARD:
      return this.simplePayment(this.GMOCreditCardPaymentMethodService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function paymentWithGiftCards(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod
  };
  const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
  return [mainPayment, ...giftCardsPayments];
}

async function simplePayment(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod: paymentMethod;
  };
  return [mainPayment];
}

async function giftPaymentOnly(paymentMethod) {
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
  return this.getGiftCardsPayments(giftCardPaymentInstruments);
}

Answer 2

Consider enabling different payment providers and their respective payment methods individually. Since each provider has its own unique requirements, avoid creating a generic function to handle all cases.

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

const getPaymentMethods = async (orderRequest) => {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenCreditCardPaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case PAYPAL:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.ADYEN_PAYPAL, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.adyenPayPalPaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case INVOICE:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.INVOICE, true);
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenInvoicePaymentMethodService
              };
              const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
              return [mainPayment, ...giftCardsPayments];
            }
          case GIFTCERTIFICATE:
            {
              const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
              return this.getGiftCardsPayments(giftCardPaymentInstruments);
            }
          case APPLEPAY:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.AdyenApplePayPaymentService
              };
              return [mainPayment];
            }
        }
        break;
      }
    case COD_PROVIDER:
      {
        switch (orderRequest.paymentMethod) {
          case COD_METHOD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CASH_ON_DELIVERY, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.CashOnDeliveryPaymentService
              };
              return [mainPayment];
            }
        }
        break;
      }
    case GMO:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            {
              const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
              const mainPayment = {
                paymentInstrument: mainPaymentInstruments[0],
                paymentMethod: this.GMOCreditCardPaymentMethodService
              };
              return [mainPayment];
            }
        }
        break;
      }
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

To simplify the logic, you may create separate functions:

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

async function getPaymentMethods(orderRequest) {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            return this.paymentWithGiftCards(this.AdyenCreditCardPaymentMethodService);
          case PAYPAL:
            return this.paymentWithGiftCards(this.adyenPayPalPaymentMethodService);
          case INVOICE:
            return this.paymentWithGiftCards(this.AdyenInvoicePaymentMethodService);
          case GIFTCERTIFICATE:
            return giftPaymentOnly();
          case APPLEPAY:
            return this.simplePayment(this.AdyenApplePayPaymentService);
        }
        break;
      }
    case COD_PROVIDER:
      {
        switch (orderRequest.paymentMethod) {
          case COD_METHOD:
            return this.simplePayment(this.CashOnDeliveryPaymentService);
        }
        break;
      }
    case GMO:
      {
        switch (orderRequest.paymentMethod) {
          case CREDITCARD:
            return this.simplePayment(this.GMOCreditCardPaymentMethodService);
        }
        break;
      }
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

async function paymentWithGiftCards(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod
  };
  const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
  return [mainPayment, ...giftCardsPayments];
}

async function simplePayment(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod: paymentMethod;
  };
  return [mainPayment];
}

async function giftPaymentOnly(paymentMethod) {
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
  return this.getGiftCardsPayments(giftCardPaymentInstruments);
}

To avoid nested switch statements, delegate each payment provider's call to specific functions:

const {
  ADYEN,
  COD: COD_PROVIDER,
  GMO
} = OrderRequestV2.PaymentProviderEnum;

const {
  APPLEPAY,
  COD: COD_METHOD,
  CREDITCARD,
  GIFTCERTIFICATE,
  INVOICE,
  PAYPAL
} = OrderRequestV2.PaymentMethodEnum;

async function getPaymentMethods(orderRequest) {
  switch (orderRequest.paymentProvider) {
    case ADYEN:
      return getAdyenPaymentMethods(orderRequest);
    case COD_PROVIDER:
      return getCodPaymentMethods(orderRequest);
    case GMO:
      return getGmoPaymentMethods(orderRequest);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
};

async function getAdyenPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case CREDITCARD:
      return this.paymentWithGiftCards(this.AdyenCreditCardPaymentMethodService);
    case PAYPAL:
      return this.paymentWithGiftCards(this.adyenPayPalPaymentMethodService);
    case INVOICE:
      return this.paymentWithGiftCards(this.AdyenInvoicePaymentMethodService);
    case GIFTCERTIFICATE:
      return giftPaymentOnly();
    case APPLEPAY:
      return this.simplePayment(this.AdyenApplePayPaymentService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function getCodPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case COD_METHOD:
      return this.simplePayment(this.CashOnDeliveryPaymentService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function getGmoPaymentMethods(orderRequest) {
  switch (orderRequest.paymentMethod) {
    case CREDITCARD:
      return this.simplePayment(this.GMOCreditCardPaymentMethodService);
  }
  throw new BadRequestError(`${ERRORS.PLACE_ORDER_V2_PREFIX} Please verify your request`);
}

async function paymentWithGiftCards(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.CREDIT_CARD, true);
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod
  };
  const giftCardsPayments = this.getGiftCardsPayments(giftCardPaymentInstruments);
  return [mainPayment, ...giftCardsPayments];
}

async function simplePayment(paymentMethod) {
  const mainPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.APPLE_PAY, true);
  const mainPayment = {
    paymentInstrument: mainPaymentInstruments[0],
    paymentMethod: paymentMethod;
  };
  return [mainPayment];
}

async function giftPaymentOnly(paymentMethod) {
  const giftCardPaymentInstruments = await this.pickPaymentInstruments(basket, constants.PAYMENT_METHODS.GIFT_CERTIFICATE, true);
  return this.getGiftCardsPayments(giftCardPaymentInstruments);
}

Improve numerous conditions

Answer №1

Similar questions

Troubleshooting React on an Apache Server: A Comprehensive Guide

Combine multiple arrays in JavaScript into a single array

Reaching out to the Edge: Enhancing the jQuery Slider Experience

React modal not triggered on click event

Creating an HTML layout or template directly within a JavaScript bookmarklet

Tips for implementing a search function with DynamoDB using the "contains" operator

Struggling with sending intricate model to controller via ajax request

Transforming the output of a PHP script from an HTML table into an ion-list format tailored for the Ionic framework

Adding Bootstrap component via ajax request

"The issue with ExpressJS deleteRoute is that it is not properly refreshing user

Switch from using `widthWidth` to `useWidth` in MUI v5 ReactJS

Unveil the socket connection using web sockets

Choosing the perfect gradient shade for a progress bar canvas illustration: Tips and tricks

How can JavaScript be used to parse an XML file? Should we consider using SAX for handling large XML files

What steps can you take to address Git conflicts within the yarn.lock file?

Troubleshooting: Issues with jQuery.on method functionality

Preparing JSON data for creating a wind map with Leaflet

Tips for implementing AngularJS on a webpage transfer

Struggling to link variables and functions to an angularJS controller

When Vue.js is compiled, it removes a script tag