I'm constantly running into a logic issue that is causing my array output to be filled with zeros

Question

I'm constantly running into a logic issue that is causing my array output to be filled with zeros

I seem to have encountered a tricky logic error in my code where the output is not as expected due to values not being returned correctly. I'm seeking guidance on how to troubleshoot this issue. Before delving into that, let me provide some context about what's happening. In the main section of my code, I am assigning values to an array 'x' which should then be passed to another file called getAllEvens. However, somewhere in the process, the values get altered or are not carried over properly, resulting in all zeros being displayed instead. Any suggestions or assistance would be greatly appreciated. Please aim to align your advice with the structure of my code or utilize simpler methods since this is for a school project. Let's proceed to the actual code.

Here is the code snippet from the main:

`int[] x = {2,4,6,8,10,12,14};
 int[] x = {2,4,6,8,10,12,14};
 int[] y = {1,2,3,4,5,6,7,8,9};
 int[] z = {2,10,20,21,23,24,40,55,60,61};

 System.out.println("Odds - " + Arrays.toString(OddsAndEvens.getAllOdds(x)));
 System.out.println("Evens - " + Arrays.toString(OddsAndEvens.getAllEvens(x)));

And this is the corresponding section in the other file:

private static int[] cf = new int[20];
public static int countEm(int[] array, boolean odd)
{
    cf=array;
    return 0;
}
public static int[] getAllEvens(int[] array)
{
        int[]vegeta = new int[20];
        int VegetaScouterCount = 0;
        int[] XboxThreeYearOld = new int[20];
        for(int f : cf)
        {

            if(array[f]%2==0)
            {
                vegeta[VegetaScouterCount]=cf[f];
                VegetaScouterCount++;
                XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
            }
            XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
        }
        return XboxThreeYearOld;
}

(Ignore any informal language used)

The current output looks like:

Odds - []
Evens - [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]

The desired output should be:

Odds - []
Evens - [2, 4, 6, 8, 10, 12, 14]

I would really appreciate any pointers or hints in helping me resolve this issue.

java javascript arrays

Answer 1

Answer №1

The cf array needs to be initialized in Java to avoid default values being assigned, which results in each element having a value of zero.

In addition, using the uninitialized cf array (filled with zeros) to check for even numbers will always result in 0 % 2.

Furthermore, assigning elements from cf to vegeta, and subsequently copying it to

XboxThreeYearOld</code, will populate the returned array with zeroes.</p>

<p>To address this issue, consider the following code snippet:</p>

<pre><code>for (int i = 0; i < array.length; i++) {
    if (array[i] % 2 == 0) {
        vegeta[VegetaScouterCount] = array[i];
        VegetaScouterCount++;
        XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
    }
    XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
}

Answer 2

The cf array needs to be initialized in Java to avoid default values being assigned, which results in each element having a value of zero.

In addition, using the uninitialized cf array (filled with zeros) to check for even numbers will always result in 0 % 2.

Furthermore, assigning elements from cf to vegeta, and subsequently copying it to

XboxThreeYearOld</code, will populate the returned array with zeroes.</p>

<p>To address this issue, consider the following code snippet:</p>

<pre><code>for (int i = 0; i < array.length; i++) {
    if (array[i] % 2 == 0) {
        vegeta[VegetaScouterCount] = array[i];
        VegetaScouterCount++;
        XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
    }
    XboxThreeYearOld = Arrays.copyOfRange(vegeta, 0, VegetaScouterCount);
}

Answer 3

Answer №2

Here is a suggestion for your code:

for(int f : cf)
{
  if(array[f]%2==0)
  {

The above snippet accesses the value at index f of array and checks if it is even. Perhaps you meant to check if the number itself (f) is even.

for(int f : array)
{
  if(f%2==0)

To improve your code, consider implementing a method to count the number of even values in an array:

static int countEvens(int[] arr) {
    int count = 0;
    for (int i : arr) {
        if (i % 2 == 0) {
            count++;
        }
    }
    return count;
}

You can then use this method to separate the odds and evens:

static int[] getAllEvens(int[] array) {
    int[] evens = new int[countEvens(array)];
    int pos = 0;
    for (int f : array) {
        if (f % 2 == 0) {
            evens[pos++] = f;
        }
    }
    return evens;
}

And to get all the odd numbers:

static int[] getAllOdds(int[] array) {
    int[] odds = new int[array.length - countEvens(array)];
    int pos = 0;
    for (int f : array) {
        if (f % 2 != 0) {
            odds[pos++] = f;
        }
    }
    return odds;
}

Answer 4

Here is a suggestion for your code:

for(int f : cf)
{
  if(array[f]%2==0)
  {

The above snippet accesses the value at index f of array and checks if it is even. Perhaps you meant to check if the number itself (f) is even.

for(int f : array)
{
  if(f%2==0)

To improve your code, consider implementing a method to count the number of even values in an array:

static int countEvens(int[] arr) {
    int count = 0;
    for (int i : arr) {
        if (i % 2 == 0) {
            count++;
        }
    }
    return count;
}

You can then use this method to separate the odds and evens:

static int[] getAllEvens(int[] array) {
    int[] evens = new int[countEvens(array)];
    int pos = 0;
    for (int f : array) {
        if (f % 2 == 0) {
            evens[pos++] = f;
        }
    }
    return evens;
}

And to get all the odd numbers:

static int[] getAllOdds(int[] array) {
    int[] odds = new int[array.length - countEvens(array)];
    int pos = 0;
    for (int f : array) {
        if (f % 2 != 0) {
            odds[pos++] = f;
        }
    }
    return odds;
}

Answer 5

Answer №3

If you don't actually need an array, using a dynamic collection like Sets or Lists might be more efficient. However, in the current structure, the for each loop is being used incorrectly.

The variable 'f' does not represent an index, but rather the value of 'cf' for each position. Since 'cf' has been initialized with a length of 20 and filled with zeros, it will always return 0.

Try using a traditional for loop like this:

for (int i=0; i<cf.length;i++){ // do work here }

and observe the output.

There could be other logical errors that the compiler may not detect since they are not related to syntax or data types.

Answer 6

If you don't actually need an array, using a dynamic collection like Sets or Lists might be more efficient. However, in the current structure, the for each loop is being used incorrectly.

The variable 'f' does not represent an index, but rather the value of 'cf' for each position. Since 'cf' has been initialized with a length of 20 and filled with zeros, it will always return 0.

Try using a traditional for loop like this:

for (int i=0; i<cf.length;i++){ // do work here }

and observe the output.

There could be other logical errors that the compiler may not detect since they are not related to syntax or data types.

Answer 7

Answer №4

In order to display the odd and even numbers, make sure to first execute the countem() method.
To resolve the issue, update
```
vegeta[VegetaScouterCount]=cf[f];
```
to
```
vegeta[VegetaScouterCount]=array[f];
```
. The problem arises from the fact that your array cf was initialized with a size of 20, but all its indexes default to 0 until explicitly changed.

Answer 8

In order to display the odd and even numbers, make sure to first execute the countem() method.
To resolve the issue, update
```
vegeta[VegetaScouterCount]=cf[f];
```
to
```
vegeta[VegetaScouterCount]=array[f];
```
. The problem arises from the fact that your array cf was initialized with a size of 20, but all its indexes default to 0 until explicitly changed.

I'm constantly running into a logic issue that is causing my array output to be filled with zeros

Answer №1

Answer №2

Answer №3

Answer №4

Similar questions

In JavaScript, you can update the class named "active" to become the active attribute for a link

What is the best way to access a cached value?

Angular's jQuery timepicker allows users to easily select a

Swapping out the current div with the outcome from jQuery

Angular 2 System.config map leading to a 404 error message

What is the process for deleting a token from local storage and displaying the logout page in Next JS?

"Encountering a strpos() issue while working with the Simple HTML DOM

Using Java 8 Lambdas to Reset a Variable Conditionally Before Populating

There was an unusual bug related to the sizeof() function that occurred while using DevC

Can the hasClass() function be applied to querySelectorAll() in JavaScript?

The settings in spring.jackson.properties seem to be overlooked by Jackson in my Spring Boot application

Using Browserify to fetch external JSON data

Select an item, then toggle classes on the other items to add or remove them

Finding the Sum and Average of an Array

Is there a way to extract subtitles from a javascript-controlled webpage using Python?

Creating a custom theme for a tree panel in Ext JS 4

Ways to invoke a function from the parent component that is delegated as a prop to the child component

Combining Django's CSRF token with AngularJS

using jquery to fill in fields in a table form

Creating a custom filter in an ng-repeat table using AngularJS