Functions for abbreviating and combining strings in Javascript

Question

Functions for abbreviating and combining strings in Javascript

Looking for help to simplify and shorten a Javascript function:

$scope.doRefresh = function (){
    if($scope.bulletpointPopular){
      ArticleService.popular().then(function(data){
        $scope.articles = data;
      })
      .finally(function() {
         $scope.$broadcast('scroll.refreshComplete');
       });
    }
    else {
      ArticleService.all().then(function(data){
        $scope.articles = data;
      })
      .finally(function() {
         $scope.$broadcast('scroll.refreshComplete');
       });
    }
  };

Simplified version attempted:

$scope.doRefresh = function (){
        if($scope.bulletpointPopular){
          $scope.popular();
        }
        else {
          $scope.latest();
        }
        .finally(function() {
             $scope.$broadcast('scroll.refreshComplete');
           });
      };

Error message received:

Uncaught SyntaxError: Unexpected token .

javascript angularjs

Answer 1

Answer №1

$scope.refreshArticles = function (){
    var type = $scope.bulletpointPopular? 'popular': 'all';

    ArticleService[type]().then(function(data){
       $scope.articles = data;
    }).finally(function() {
       $scope.$broadcast('scroll.refreshComplete');
    });
};

Interesting approach. The key difference lies in the conditional statement determining which function to call on ArticleService. It's a smart move to store this decision as a variable and access it dynamically from ArticleService.

Alternatively

$scope.refreshArticles = function (){
    var promise = $scope.bulletpointPopular? ArticleService.popular(): ArticleService.all();

    promise.then(function(data){
       $scope.articles = data;
    }).finally(function() {
       $scope.$broadcast('scroll.refreshComplete');
    });
};

In this scenario, depending on the boolean value, the corresponding function is invoked to get the promise returned for resolution.

Answer 2

$scope.refreshArticles = function (){
    var type = $scope.bulletpointPopular? 'popular': 'all';

    ArticleService[type]().then(function(data){
       $scope.articles = data;
    }).finally(function() {
       $scope.$broadcast('scroll.refreshComplete');
    });
};

Interesting approach. The key difference lies in the conditional statement determining which function to call on ArticleService. It's a smart move to store this decision as a variable and access it dynamically from ArticleService.

Alternatively

$scope.refreshArticles = function (){
    var promise = $scope.bulletpointPopular? ArticleService.popular(): ArticleService.all();

    promise.then(function(data){
       $scope.articles = data;
    }).finally(function() {
       $scope.$broadcast('scroll.refreshComplete');
    });
};

In this scenario, depending on the boolean value, the corresponding function is invoked to get the promise returned for resolution.

Answer 3

Answer №2

Here is a way to achieve this:

$scope.popularPosts = function() {
    return PostService.getPopularPosts();
};
$scope.latestPosts = function() {
    return PostService.getAllPosts();
};
$scope.refreshPosts = function() {
    ($scope.showPopular ? $scope.popularPosts() : $scope.latestPosts()).then(function(data) {
        $scope.posts = data;
    }).finally(function() {
        $scope.$broadcast('scroll.refreshComplete');
    });
};

Answer 4

Here is a way to achieve this:

$scope.popularPosts = function() {
    return PostService.getPopularPosts();
};
$scope.latestPosts = function() {
    return PostService.getAllPosts();
};
$scope.refreshPosts = function() {
    ($scope.showPopular ? $scope.popularPosts() : $scope.latestPosts()).then(function(data) {
        $scope.posts = data;
    }).finally(function() {
        $scope.$broadcast('scroll.refreshComplete');
    });
};

Answer 5

Answer №3

I'm not totally clear on the reasoning behind your code, but one way to simplify it could be by creating a new method in ArticleService that takes an input parameter called bulletpointPopular. This new method would then decide whether to call the popular() or all() function based on the value of bulletpointPopular. Implementing this change would make your code shorter and cleaner.

$scope.doRefresh = function (){
    ArticleService.newMethod($scope.bulletpointPopular).then(function(data){
        $scope.articles = data;
      })
      .finally(function() {
         $scope.$broadcast('scroll.refreshComplete');
       });
};

Answer 6

I'm not totally clear on the reasoning behind your code, but one way to simplify it could be by creating a new method in ArticleService that takes an input parameter called bulletpointPopular. This new method would then decide whether to call the popular() or all() function based on the value of bulletpointPopular. Implementing this change would make your code shorter and cleaner.

$scope.doRefresh = function (){
    ArticleService.newMethod($scope.bulletpointPopular).then(function(data){
        $scope.articles = data;
      })
      .finally(function() {
         $scope.$broadcast('scroll.refreshComplete');
       });
};

Functions for abbreviating and combining strings in Javascript

Answer №1

Answer №2

Answer №3

Similar questions

Creating a Select component in React without relying on the Material-UI library involves customizing a dropdown

Tips on finding the key associated with a specific value

What makes it possible for Vue v3 to handle variables that are undefined?

Namespace remains ambiguous following compilation

Execute and showcase code without redundancies

"Looking for a way to automatically close the <li> tag in Vuejs when clicked outside

Integrating XML API Requests Using HTML and JavaScript

The Vue.js error message "Unable to access property 'array_name' as it is undefined" indicates an issue with

Utilize JavaScript to extract content from a text file and showcase it in a Bootstrap modal pop-up through knockout binding

Tips for simulating or monitoring a function call from a separate file

What is the best way to ensure that the content container's max-width for a split tier is the same as the width of a full-width tier?

Executing SQL queries in JavaScript using PHP functions

Upgrade from Next.js version 12

The "util" module has been extracted to ensure compatibility with browsers. Trying to use "util.promisify" in client code is not possible

The JavaScript file fails to load when accessing port 8080

The functionality of the document download button using Express.js and node.js appears to be malfunctioning

An Easy Method for Managing Files in a Node.js Directory: Editing and Deleting Made Simple

Vue JS encountering Slack API CORS issue while using axios

IntelliJ has removed the connect-flash plugin, preventing me from reinstalling it

Tips for creating a login page with AngularJS