Challenges Associated with Promises in JavaScript

Question

Challenges Associated with Promises in JavaScript

I'm having trouble with the last line of code in my program and I need some help figuring out how to fix it. Specifically, I know that the second "then" statement needs to return resolve() but I'm not sure how to go about implementing this. Any tips or suggestions would be greatly appreciated!

let getNumber = new Promise((resolve) => {
    //API call
    EthereumNote.getAmountOfMyNotes(function(error, result) {
        if (!error) {
            let AmountOfMyNotes = Number(result)
            resolve(AmountOfMyNotes)
            console.log(result)
        } else
            console.error(error)

    })
}).then(result => {
    return new Promise((resolve) => {
        for (let i = 0, p = Promise.resolve(); i < result; i++) {
            p = p.then(_ => new Promise(resolve => {
                //Another API call
                EthereumNote.getMyNote(i, function(error, result) {
                    if (!error) {
                        let text = String(result[0])
                        let noteID = Number(result[1])
                        console.log(text)
                        console.log(noteID)
                        resolve()
                    } else
                        console.error(error)
                })
            }));
        }
    })
}).then(() => console.log('Hi!')) // Having trouble with this part

javascript ecmascript-6 es6-promise

Answer 1

Answer №1

Avoid falling into the trap of using the Promise constructor antipattern. It's fine to create a new promise to encapsulate EthereumNote.getMyNote, but be cautious about wrapping it in a loop without ever resolving the outer promise.

Instead, simply return the chain of promises created in p:

let getNumber = new Promise((resolve) => {
    //API
    EthereumNote.getAmountOfMyNotes(function(error, result) {
        if (error) reject(error);
        else resolve(Number(result));
    })
}).then(amountOfMyNotes => {
    console.log(amountOfMyNotes);
    var p = Promise.resolve();
    for (let i = 0; i < amountOfMyNotes; i++) {
        p = p.then(_ => new Promise((resolve, reject) => {
            //API
            EthereumNote.getMyNote(i, function(error, result) {
                if (error) reject(error);
                else resolve(result);
            });
        })).then(result => {
            let text = String(result[0])
            let noteID = Number(result[1])
            console.log(text)
            console.log(noteID))
        });
    }
    return p;
}).then(() => {
    console.log('Hi!'); // this one now works
}, err => {
    console.error(err);
});

Answer 2

Avoid falling into the trap of using the Promise constructor antipattern. It's fine to create a new promise to encapsulate EthereumNote.getMyNote, but be cautious about wrapping it in a loop without ever resolving the outer promise.

Instead, simply return the chain of promises created in p:

let getNumber = new Promise((resolve) => {
    //API
    EthereumNote.getAmountOfMyNotes(function(error, result) {
        if (error) reject(error);
        else resolve(Number(result));
    })
}).then(amountOfMyNotes => {
    console.log(amountOfMyNotes);
    var p = Promise.resolve();
    for (let i = 0; i < amountOfMyNotes; i++) {
        p = p.then(_ => new Promise((resolve, reject) => {
            //API
            EthereumNote.getMyNote(i, function(error, result) {
                if (error) reject(error);
                else resolve(result);
            });
        })).then(result => {
            let text = String(result[0])
            let noteID = Number(result[1])
            console.log(text)
            console.log(noteID))
        });
    }
    return p;
}).then(() => {
    console.log('Hi!'); // this one now works
}, err => {
    console.error(err);
});

Challenges Associated with Promises in JavaScript

Answer №1

Similar questions

Having trouble with installing NPM and ng commands, neither of them is working. I may have to uninstall everything and begin from scratch

Ways to remove any messages containing URLs that are not www.youtube.com or www.twitter.com

Using Jquery to change an id with the .attr method may not always produce the desired results

Display alert only when focus is lost (on blur) and a dropdown selection was not made

Is locking Node and npm versions necessary for frontend framework projects?

What is the best way to locate a div element with a specific style?

Is it possible to incorporate several modules into nodeJS simultaneously?

Ways to retrieve the text linked to a checkbox

ng serve issue persists even after resolving vulnerabilities

What is the easiest way to locate the ID of an iframe embedded within a webpage?

The Link component in the router dom should only be active when validation passes successfully

Tips for extracting the chosen value from a dropdown list within a table cell using JavaScript

Using a table row as a counter in HTML

Modifying various states within React using the useState() hook

jQuery struggles to process large response

What is the most efficient way to use the $slice operator on a highly nested array in mongoose

Transform an array of strings into an array of object IDs

Trouble with Vuex Store: Changes to table values not reflected in store

Adjusting the height of the search icon through the Jquery toggle action to create animated effects

Currently, I am experiencing difficulties with two specific aspects of the website I am working on - the hamburger menu and the slideshow feature